Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Update Kamel bind step index in properties to start at 1 instead of 0 #3884

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Dec 8, 2022

fixes #2586

Motivation

The kamel bind command uses 0 index start for the definition of step properties :

kamel bind ... --step my-step-1 --step my-step-2 -p step-0.my-key=value1 -p step-1.my-key=value2

Having an index start at 1 is more user friendly :

kamel bind ... --step my-step-1 --step my-step-2 -p step-1.my-key=value1 -p step-2.my-key=value2

Modifications

  • Modify the transformation from command to spec for steps in biding command code
  • Add a unit test on step values

Release Note

feat(cli): Update Kamel bind step index in properties to start at 1 instead of 0

@gansheer gansheer marked this pull request as ready for review December 8, 2022 16:07
@squakez squakez merged commit 738d39e into apache:main Dec 12, 2022
@squakez
Copy link
Contributor

squakez commented Dec 12, 2022

Thanks for your contribution!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kamel bind step index unclear
3 participants