New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code #2751

Closed

6 tasks done

squakez opened this issue Nov 16, 2021 · 4 comments · Fixed by #2932

Closed

6 tasks done

Remove deprecated code #2751

squakez opened this issue Nov 16, 2021 · 4 comments · Fixed by #2932

Assignees

Labels

kind/task

Contributor

squakez commented Nov 16, 2021 •

edited

Loading

We have a few deprecated things around the code we may fix in the next releases:

Remove older config flags (ie, secret, configmap and property-file flag)
Remove DeprecatedConfigMap in master addon trait
Remove Timeout in MavenSpec
Remove Kit from IntegrationSpec
Remove Flow from KameletSpec
Remove NewFilteredSharedInformerFactory

@astefanutti @nicolaferraro can you please confirm we should be fine removing all this stuff?

The text was updated successfully, but these errors were encountered:

Member

astefanutti commented Nov 16, 2021

That looks good to me. There is also the container trait configuration parameters related to health checks that are deprecated and that we may want to remove as well.

astefanutti added the kind/task label

Contributor Author

squakez commented Nov 16, 2021

That looks good to me. There is also the container trait configuration parameters related to health checks that are deprecated and that we may want to remove as well.

I think it was deprecated quite recently. I'd wait for at least one more major upgrade before removing that one.

Member

astefanutti commented Nov 16, 2021

That looks good to me. There is also the container trait configuration parameters related to health checks that are deprecated and that we may want to remove as well.

I think it was deprecated quite recently. I'd wait for at least one more major upgrade before removing that one.

Right, that sounds good. The others you've listed are older enough.

Contributor

phantomjinx commented Dec 10, 2021

Looking at e2e tests, property-file also appears deprecated too.

Warn: --configmap has been deprecated. You should use --config configmap:my-configmap instead.
Warn: --secret has been deprecated. You should use --config secret:my-secret instead.
Warn: --property-file has been deprecated. You should use --property file:/path

squakez mentioned this issue

Remove usage of deprecated "flow" in Kamelet CRD in the documentation examples #2816

Closed

squakez self-assigned this

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

18bf22e

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

5e78e66

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Timeout in MavenSpec

85ec7ef

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

9086f00

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Flow from KameletSpec

cafeb18

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

73f6428

 Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: remove deprecated code

3d67889

Closes apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

24b903a

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

d413f91

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Timeout in MavenSpec

d882a75

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

e5c433a

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Flow from KameletSpec

c637a04

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

0f9cd88

 Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: remove deprecated code

1f012bb

Closes apache#2751

squakez mentioned this issue

chore: remove deprecated code in pre 1.6 releases #2932

Merged

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

ca4b5e4

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

161632d

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Timeout in MavenSpec

d294790

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

9feb74f

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Flow from KameletSpec

cba6463

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

eb34bd6

 Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: remove deprecated code

6a3bb25

Closes apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

799fd44

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

be4973c

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

e10444c

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Timeout in MavenSpec

a09b57d

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

2311ea9

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Flow from KameletSpec

ea1b909

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

b7de8aa

 Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: remove deprecated code

c01c3da

Closes apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

e0e0c35

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

265b58f

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Timeout in MavenSpec

df7f65c

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

28aa8ca

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Flow from KameletSpec

1654c33

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

ab62f7c

 Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: remove deprecated code

dcc8def

Closes apache#2751

christophd mentioned this issue

[WIP] chore: remove deprecated code in pre 1.6 releases #3016

Closed

squakez added a commit to squakez/camel-k that referenced this issue


          chore(cmd): remove deprecated flags

636cf93

* --property-file
* --configmap
* -- secret

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

2b101c2

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Timeout in MavenSpec

4faadc0

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

181b69b

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore(api): Remove Flow from KameletSpec

2c24e8c

Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

639bf01

 Ref apache#2751

squakez added a commit to squakez/camel-k that referenced this issue


          chore: remove deprecated code

b9677f1

Closes apache#2751

squakez closed this as completed in #2932

squakez added a commit that referenced this issue


          chore(cmd): remove deprecated flags

118e352

* --property-file
* --configmap
* -- secret

Ref #2751

squakez added a commit that referenced this issue


          chore(trait/master): Remove DeprecatedConfigMap

fee3b91

Ref #2751

squakez added a commit that referenced this issue


          chore(api): Remove Timeout in MavenSpec

b772eb2

Ref #2751

squakez added a commit that referenced this issue


          chore(api): Remove Kit from IntegrationSpec

55d6f67

Ref #2751

squakez added a commit that referenced this issue


          chore(api): Remove Flow from KameletSpec

51ef518

Ref #2751

squakez added a commit that referenced this issue


          chore: Remove NewFilteredSharedInformerFactory

89a2222

 Ref #2751

squakez added a commit that referenced this issue


          chore: remove deprecated code

02be54b

Closes #2751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment