Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KameletBinding - Make error handler more simpler #2815

Closed
davsclaus opened this issue Dec 7, 2021 · 2 comments · Fixed by #2843
Closed

KameletBinding - Make error handler more simpler #2815

davsclaus opened this issue Dec 7, 2021 · 2 comments · Fixed by #2843
Assignees

Comments

@davsclaus
Copy link
Contributor

A binding is intended to be high level and fairly simple.
https://camel.apache.org/camel-k/1.7.x/kamelets/kameletbindings-error-handler.html

I wonder if we have not made the error handler a bit too complex with the bean and ref. What is the purpose of those. As they require the user to implement a custom error handler builder (which nobody really does in core camel).

I wonder if we can deprecate and remove those, or did you find a use-case for them somehow in camel-k?

@davsclaus
Copy link
Contributor Author

@squakez any thoughts?

@squakez
Copy link
Contributor

squakez commented Dec 7, 2021

Yeah, I think the direct usage of them can be hidden to the final user, but cannot be removed (at least ref) as it's the foundation of the feature itself (see

"ref": t.ErrorHandlerRef,
). When I developed originally the feature, I exposed all the low level implementations to collect feedback on possible advanced use case. I don't see any added value to the user, so, I agree we can remove the option. Also @lburgazzoli was involved on the design, maybe he had in mind some other use case I ignore.

@squakez squakez self-assigned this Dec 27, 2021
squakez added a commit to squakez/camel-k that referenced this issue Dec 27, 2021
squakez added a commit to squakez/camel-k that referenced this issue Dec 27, 2021
squakez added a commit that referenced this issue Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants