Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kamelet): remove bean and ref error handler types #2843

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Dec 27, 2021

  • Remove bean and ref error handlers
  • Deprecate dead-letter-channel in favour of sink

Closes #2815

Release Note

chore(kamelet): polish error handler

@squakez
Copy link
Contributor Author

squakez commented Dec 27, 2021

FYI @davsclaus

@davsclaus
Copy link
Contributor

Added ticket for camel core to support sink
https://issues.apache.org/jira/browse/CAMEL-17388

@squakez
Copy link
Contributor Author

squakez commented Dec 27, 2021

Added ticket for camel core to support sink https://issues.apache.org/jira/browse/CAMEL-17388

Thanks @davsclaus. I understand the issue opened for camel core is to take the opportunity and rename the definition in the core as well. However that is not required for Camel K, as we rely on the configuration of the org.apache.camel.builder.DeadLetterChannelBuilder class. If we changed the Builder class name, then we'd need to sync the implementation for Camel K as well.

@davsclaus
Copy link
Contributor

Yeah its not a problem for camel-k, its for camel core itself, with camel-jbang/karavan where we can load kamelet binding files also (for development)

@squakez squakez merged commit db75003 into apache:main Dec 28, 2021
@squakez squakez deleted the chore/2815_err_handl_polish branch December 28, 2021 10:19
@oscerd oscerd mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KameletBinding - Make error handler more simpler
2 participants