Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.10.0 Release #3560

Closed
oscerd opened this issue Aug 22, 2022 · 39 comments
Closed

1.10.0 Release #3560

oscerd opened this issue Aug 22, 2022 · 39 comments
Assignees
Milestone

Comments

@oscerd
Copy link
Contributor

oscerd commented Aug 22, 2022

We need to release a new version based on Camel 3.18.0 LTS.

What are the issues you want to add as mandatory in 1.10.0? Please add the issues here, so we can track and start a release soon.

@oscerd oscerd added this to the 1.10.0 milestone Aug 22, 2022
@oscerd oscerd self-assigned this Aug 22, 2022
@tadayosi
Copy link
Member

tadayosi commented Aug 22, 2022

There are a few open issues that are supposed to be in 1.10.0:
https://github.com/apache/camel-k/milestone/35

I think these three issues are just waiting for a new Camel K runtime release before getting merged:
#3376
#3373
#3317

The other issues are probably OK to postpone to 1.11.0 if there are no objections.

cc: @christophd @claudio4j @squakez @essobedo

@oscerd
Copy link
Contributor Author

oscerd commented Aug 22, 2022

I could start a release for camel-k-runtime and camel-kamelets

@oscerd
Copy link
Contributor Author

oscerd commented Aug 22, 2022

So we can point to staging repository.

@tadayosi
Copy link
Member

Probably we should include this to 1.10.0 as well: #3552
cc: @astefanutti

@oscerd
Copy link
Contributor Author

oscerd commented Aug 22, 2022

#3561

For alignment

@oscerd
Copy link
Contributor Author

oscerd commented Aug 24, 2022

I'm releasing again camel-k-runtime as staging repository because of apache/camel-k-runtime@857ec9a

@oscerd
Copy link
Contributor Author

oscerd commented Aug 24, 2022

What's the general situation for releasing?

@christophd
Copy link
Contributor

#3376 is ready to be merged IMO

@oscerd
Copy link
Contributor Author

oscerd commented Aug 24, 2022

#3376 Merged.

@christophd
Copy link
Contributor

@claudio4j has already rebased #3373

It is hard to say weather failing CI jobs are due to changes or general flaky nature of tests. at the moment CI jobs are not very stable

@oscerd
Copy link
Contributor Author

oscerd commented Aug 24, 2022

I think it is failing also because the staging repository is not updated on that branch.

@squakez
Copy link
Contributor

squakez commented Aug 24, 2022

#3317 has several tests failing. I'm having a look to understand why this is happening.

@squakez
Copy link
Contributor

squakez commented Aug 24, 2022

I noticed they are all the same errors happening on the main branch. In particular I can see:

org.graalvm.polyglot.PolyglotException: java.lang.IllegalStateException: Duplicate language id regex. First language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar]. Second language [Language class com.oracle.truffle.regex.RegexLanguage, Loaded from file:/deployments/dependencies/lib/main/org.graalvm.regex.regex-22.1.0.jar].

I think we either merge everything and solve on main or we solve on main, then rebase every pending PR and see each result. I'd go with the second approach which look safer.

@squakez
Copy link
Contributor

squakez commented Aug 24, 2022

Relates quarkusio/quarkus#27085

@claudio4j
Copy link
Contributor

#3373 fails are timeouts.

@tadayosi
Copy link
Member

I've pushed remaining ones to 1.11.0 milestone. Now it's only #3373 that we are waiting to be merged.
https://github.com/apache/camel-k/milestone/35

@oscerd
Copy link
Contributor Author

oscerd commented Aug 25, 2022

I re-released camel-k-runtime and updated the staging repo in main branch. We just need to wait for #3373

@squakez
Copy link
Contributor

squakez commented Aug 25, 2022

Listing here the tests I can see are still failing:

  • All test local --> fixed by fix(e2e): local test when staging #3574
  • Common tests (due to 2.11.0.Final Quarkus core dependency bug) --> Should be fixed by fix: issue inherited by Quarkus platform camel-k-runtime#878
  • --- FAIL: TestKitKnativeFullBuild (613.55s)
  • --- FAIL: TestOperatorUpgrade (286.91s)
  • [test-kamelet-cc3hvcg61tss6ro81ao0-98r28 test-1] INFO | Kamelets templates can use beans ............................... FAILED
  • [test-kamelet-no-props-cc3i7lo61tss6ro81arg-7bp28 test-1] INFO | Bind Kamelet to service ........................................ FAILED

@squakez
Copy link
Contributor

squakez commented Aug 25, 2022

Local testing are failing because the E2E is not using the staging repo. I'm working to see if it is easy to include it when present in the Makefile.

@squakez
Copy link
Contributor

squakez commented Aug 25, 2022

Knative tests seems to be resolved in https://github.com/apache/camel-k/runs/8011632479?check_suite_focus=true

squakez added a commit to squakez/camel-k that referenced this issue Aug 25, 2022
@squakez
Copy link
Contributor

squakez commented Aug 25, 2022

I've just verified that the common is still failing as the runtime still uses the bugged quarkus dependency (ie, dependencies/lib/main/org.apache.camel.quarkus.camel-quarkus-js-dsl-2.11.0.jar). I am checking why this is happening.

EDIT: camel-quarkus and quarkus platform may be different, so, the problem may not be here.

@christophd
Copy link
Contributor

christophd commented Aug 25, 2022

I have had a look at the YAKS E2E tests and optimized with using a global operator: #3573
This also seemed to stabilize the tests and reduces the job execution time a lot

squakez added a commit to squakez/camel-k that referenced this issue Aug 25, 2022
squakez added a commit to squakez/camel-k that referenced this issue Aug 25, 2022
squakez added a commit that referenced this issue Aug 25, 2022
squakez added a commit to squakez/camel-k-runtime that referenced this issue Aug 26, 2022
@squakez
Copy link
Contributor

squakez commented Aug 26, 2022

I finally manage to workaround the latest standing issue in the common check. Hopefully once this got staged, we should have a green flag to go :)

oscerd pushed a commit to apache/camel-k-runtime that referenced this issue Aug 29, 2022
@oscerd
Copy link
Contributor Author

oscerd commented Aug 29, 2022

I released a new staging release for camel-k-runtime and updated in camel-k with f44b544

@squakez
Copy link
Contributor

squakez commented Aug 29, 2022

Okey, in common check, we've solved some of the errors, but still others are there [1]. I'm listing them here:

  • --- FAIL: TestKameletBinding/test_error_handler/throw_error_test (165.07s)
  • --- FAIL: TestBindingWithImage/run_with_initial_image (2.44s)
  • --- FAIL: TestErrorHandlerTrait/Run_errored_integration_with_error_handler (164.55s)
  • --- FAIL: TestHealthTrait/Readiness_condition_with_stopped_route (756.85s)

@lburgazzoli I understood lately we changed something in the error handler. Any hints on places where we should look at by any chance?

[1] https://github.com/apache/camel-k/runs/8064025483?check_suite_focus=true

@lburgazzoli
Copy link
Contributor

Okey, in common check, we've solved some of the errors, but still others are there [1]. I'm listing them here:

* [ ]      --- FAIL: TestKameletBinding/test_error_handler/throw_error_test (165.07s)

* [ ]      --- FAIL: TestBindingWithImage/run_with_initial_image (2.44s)

* [ ]      --- FAIL: TestErrorHandlerTrait/Run_errored_integration_with_error_handler (164.55s)

* [ ]      --- FAIL: TestHealthTrait/Readiness_condition_with_stopped_route (756.85s)

@lburgazzoli I understood lately we changed something in the error handler. Any hints on places where we should look at by any chance?

I don't think we made any change yet to the error handler, or at least not something I explicit recall, do you have any pointer ?

[1] apache/camel-k/runs/8064025483?check_suite_focus=true

@squakez
Copy link
Contributor

squakez commented Aug 29, 2022

@lburgazzoli you're right. I was mislead by this commit where you fixed some log comment only.

@astefanutti
Copy link
Member

The format of the health probe has changed with the Camel upgrade, from something like map[route.context.name:camel-1 route.id:route1 route.status:Stopped] to map[check.kind:READINESS route.id:route1 route.status:Stopped]. The e2e tests assertions should be updated accordingly, and the integration monitor action might have to be adjusted as well. @davsclaus can probably provide some more insights on what change on the Camel side.

@tadayosi
Copy link
Member

@squakez @astefanutti Thanks for your input. I can take care of TestHealthTrait fix.

@squakez
Copy link
Contributor

squakez commented Aug 29, 2022

@lburgazzoli you're right. I was mislead by this commit where you fixed some log comment only.

After all, my memory is not in that bad shape... I dug a bit more and indeed there was some change in the Error Handler managment in Camel 3.17. This one introduced a regression on Camel K runtime, as one supporting method was wiped off. In order to fix this, we'll probably need to reintroduce a workaround we had in place for pre 3.10 Camel releases. Without that check, there is no way we can verify if a default error handler, as the getErrorHandlerFactory() is in charge to create one, when it is called.

I'll test it locally to see if it works and report how it goes.

fyi @davsclaus

@oscerd
Copy link
Contributor Author

oscerd commented Aug 30, 2022

What's the situation? Do we need another staging release?

@squakez
Copy link
Contributor

squakez commented Aug 30, 2022

What's the situation? Do we need another staging release?

I'm still testing the fix on the camel-k-runtime. We'll probably need a new one. I'll let you know once everything is tested locally.

squakez added a commit to squakez/camel-k-runtime that referenced this issue Aug 30, 2022
Workaround reintroduced to fix a Camel regression as specified in apache/camel-k#3560 (comment)
oscerd pushed a commit to apache/camel-k-runtime that referenced this issue Aug 30, 2022
Workaround reintroduced to fix a Camel regression as specified in apache/camel-k#3560 (comment)
@oscerd
Copy link
Contributor Author

oscerd commented Aug 31, 2022

It seems only testBindingWithImage is failing now. Do we want to release or do we want to fix it?

@tadayosi
Copy link
Member

@oscerd It must be just an issue with the test code. Should be fixed here: #3590 The other failure in install-it CI is also a test code issue #3583. I think it's good to proceed to release.

@oscerd
Copy link
Contributor Author

oscerd commented Aug 31, 2022

If we all agree I'll try to start the release today.

@oscerd
Copy link
Contributor Author

oscerd commented Aug 31, 2022

Started release process.

@oscerd
Copy link
Contributor Author

oscerd commented Aug 31, 2022

The release is on vote.

@zhaojinxin409
Copy link

@oscerd Will #3285 be included? Camel-K use almost all resource of one api-server's node because of it.

@oscerd
Copy link
Contributor Author

oscerd commented Sep 5, 2022

Yes, it will.

@oscerd oscerd closed this as completed Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants