-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(knative): Make knative broker name configurable #3373
Conversation
@christophd @squakez for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Let's keep this warm until the changes propagate to the runtime.
2b35825
to
d4fa0f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@claudio4j many thanks! some e2e tests failed. is this because the fixed Camel component is not part of Camel K yet? |
Yes, we should wait the release train of camel artifacts. |
@claudio4j will users of the component be able to listen for all events on a broker with this fix, too? At the moment users need to filter for a given event type and can not listen for all events on that broker. |
Yes, there is a e2e knative-broker test that checks all messages are received.
No need for filtering to listen for all events, the following trigger spec was generated by camel-k-operator.
|
@claudio4j awesome! this is a much appreciated enhancement |
@claudio4j can we rebase this please? |
apache#2864 * Add e2e knative tests * Change the kamelet-binding-broker yaks test to use a custom broker name
d4fa0f5
to
2ff0172
Compare
rebased. |
I see all of the failing CI tests are timeouts. |
For what I could see, the check errors are the same we are experincing on |
#2864
Release Note