Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLM installtion needs to set KAMEL_OPERATOR_ID EnvVar #3657

Closed
christophd opened this issue Sep 19, 2022 · 0 comments · Fixed by #3660
Closed

OLM installtion needs to set KAMEL_OPERATOR_ID EnvVar #3657

christophd opened this issue Sep 19, 2022 · 0 comments · Fixed by #3660
Labels
area/olm Related to the Operator Lifecycle Manager
Milestone
1.10.1

Comments

@christophd
Copy link
Contributor

christophd commented Sep 19, 2022 •
edited
Loading

Since 1.10.x the Camel K operator uses an operator ID to identify resources that should be reconciled. The operator looks for an envvar setting named KAMEL_OPERATOR_ID to obtain its own operator id.

When installing the operator via OLM this envvar KAMEL_OPERATOR_ID is not set. Instead the OLM installation uses OPERATOR_ID as an envvar setting.

This results in an empty operator id and the operator will not reconcile resources with operator id annotation = camel-k (default since 1.10.x).

As a workaround users need to set KAMEL_OPERATOR_ID envvar manually on the CSV after installation.

As a fix we should support both KAMEL_OPERATOR_ID or OPERATOR_ID envvar when obtaining the operator id setting. Or we should only use one envvar setting consistently.
@christophd christophd mentioned this issue Sep 19, 2022
Closed
@squakez squakez added this to the 1.10.1 milestone Sep 20, 2022
@squakez squakez added the area/olm Related to the Operator Lifecycle Manager label Sep 20, 2022
christophd added a commit to christophd/camel-k that referenced this issue Sep 20, 2022
@christophd
fix(apache#3657): Use OPERATOR_ID EnvVar consistently
bbdc82c 
The code base was using both `KAMEL_OPERATOR_ID` and `OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation as `KAMEL_OPERATOR_ID` has been missing. Simplify things by using only `OPERATOR_ID` as EnvVar setting. Still support `KAMEL_OPERATOR_ID` when reading the operator id from environment settings for backward compatibility reasons.
@christophd christophd mentioned this issue Sep 20, 2022
Merged
christophd pushed a commit to christophd/camel-k that referenced this issue Sep 27, 2022
@tadayosi @christophd
fix(apache#3657): Also use OPERATOR_ID EnvVar to obtain the operator id
e7ac76b 
The code base was using exclusively `KAMEL_OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation because `KAMEL_OPERATOR_ID` is not being used in this kind of installation. Simplify things by using also using `OPERATOR_ID` when obtaining an operator id from EnvVar settings. Still support `KAMEL_OPERATOR_ID` when installing via `kamel install` in order to overwrite the default id given in the CRDs.
christophd added a commit to christophd/camel-k that referenced this issue Sep 27, 2022
@christophd
fix(apache#3657): Also use OPERATOR_ID EnvVar to obtain the operator id
dd4a75d 
The code base was using exclusively `KAMEL_OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation because `KAMEL_OPERATOR_ID` is not being used in this kind of installation. Simplify things by using also using `OPERATOR_ID` when obtaining an operator id from EnvVar settings. Still support `KAMEL_OPERATOR_ID` when installing via `kamel install` in order to overwrite the default id given in the CRDs.
oscerd pushed a commit that referenced this issue Sep 27, 2022
@christophd @oscerd
fix(#3657): Also use OPERATOR_ID EnvVar to obtain the operator id
62780a8 
The code base was using exclusively `KAMEL_OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation because `KAMEL_OPERATOR_ID` is not being used in this kind of installation. Simplify things by using also using `OPERATOR_ID` when obtaining an operator id from EnvVar settings. Still support `KAMEL_OPERATOR_ID` when installing via `kamel install` in order to overwrite the default id given in the CRDs.
christophd added a commit to christophd/camel-k that referenced this issue Sep 27, 2022
@christophd
fix(apache#3657): Also use OPERATOR_ID EnvVar to obtain the operator id
dae3d19 
The code base was using exclusively `KAMEL_OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation because `KAMEL_OPERATOR_ID` is not being used in this kind of installation. Simplify things by using also using `OPERATOR_ID` when obtaining an operator id from EnvVar settings. Still support `KAMEL_OPERATOR_ID` when installing via `kamel install` in order to overwrite the default id given in the CRDs.
oscerd pushed a commit that referenced this issue Sep 29, 2022
@christophd @oscerd
fix(#3657): Also use OPERATOR_ID EnvVar to obtain the operator id
75dfcf7 
The code base was using exclusively `KAMEL_OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation because `KAMEL_OPERATOR_ID` is not being used in this kind of installation. Simplify things by using also using `OPERATOR_ID` when obtaining an operator id from EnvVar settings. Still support `KAMEL_OPERATOR_ID` when installing via `kamel install` in order to overwrite the default id given in the CRDs.
@christophd christophd mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/olm Related to the Operator Lifecycle Manager
Projects
None yet
Milestone
1.10.1
Development

Successfully merging a pull request may close this issue.

fix(#3657): Use OPERATOR_ID EnvVar consistently christophd/camel-k
2 participants
@christophd @squakez