fix(#3657): Use OPERATOR_ID EnvVar consistently #3660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Sep 20, 2022
squakez
approved these changes
Sep 20, 2022
tadayosi
approved these changes
Sep 26, 2022
|
This test is repeatedly complaining with: |
christophd
force-pushed
the
issue/3657/operator-id-envvar
branch
from
bbdc82c
to
e7ac76b
Compare
|
@christophd Maybe you should rebase it with main and force push again. |
The code base was using exclusively `KAMEL_OPERATOR_ID` as environment setting to identify the operator id. This caused problems after OLM based installation because `KAMEL_OPERATOR_ID` is not being used in this kind of installation. Simplify things by using also using `OPERATOR_ID` when obtaining an operator id from EnvVar settings. Still support `KAMEL_OPERATOR_ID` when installing via `kamel install` in order to overwrite the default id given in the CRDs.
christophd
force-pushed
the
issue/3657/operator-id-envvar
branch
from
e7ac76b
to
dd4a75d
Compare
|
@tadayosi thanks. Let's see how it goes ... |
|
wow, all green! |
|
This could be merged. |
|
Do we need to backport to 1.10.x too? |
|
@oscerd thanks for merging! and yes, this is for 1.10.x, too |
|
Can you please create a backport pr? |
|
sure #3680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code base was using exclusively
KAMEL_OPERATOR_IDas environment setting to identify the operator id. This caused problems after OLM based installation becauseKAMEL_OPERATOR_IDis not being used in this kind of installation. Simplify things by using also usingOPERATOR_IDwhen obtaining an operator id from EnvVar settings. Still supportKAMEL_OPERATOR_IDwhen installing viakamel installin order to overwrite the default id given in the CRDs.Fixes #3657
Release Note