Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor master trait to use camel-quarkus-kubernetes #4048

Closed
claudio4j opened this issue Feb 10, 2023 · 6 comments · Fixed by #5269
Closed

Refactor master trait to use camel-quarkus-kubernetes #4048

claudio4j opened this issue Feb 10, 2023 · 6 comments · Fixed by #5269

Comments

@claudio4j
Copy link
Contributor

The functionality of camel-k-master is present in camel-quarkus-kubernetes.

We should refactor camel-k master trait to use the camel-quarkus-kubernetes.

@claudio4j claudio4j self-assigned this Feb 10, 2023
@claudio4j
Copy link
Contributor Author

@squakez @christophd wdyt ?

@squakez
Copy link
Contributor

squakez commented Mar 27, 2023

Subtask of #4166

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@squakez
Copy link
Contributor

squakez commented Jun 28, 2023

@claudio4j I understand this is something we're not planning to release in the first version of Camel K 2, right?

@claudio4j
Copy link
Contributor Author

You are correct, not planned to release for 2.0.

@squakez squakez modified the milestones: 2.0.0, 2.1.0 Jul 27, 2023
@squakez squakez modified the milestones: 2.1.0, 2.2.0 Oct 17, 2023
@squakez squakez modified the milestones: 2.2.0, 2.3.0 Jan 8, 2024
@squakez
Copy link
Contributor

squakez commented Feb 26, 2024

The new implementation is available in https://github.com/squakez/camel-k/tree/feat/4048 - however it misses the support for build properties which conflicts with maven properties. The actual required property quarkus.camel.cluster.kubernetes.labels."camel.apache.org/integration"=xyz cannot be used into xml properties. As soon as we solve that problem we can use it.

The final result would be like in #5090

squakez added a commit to squakez/camel-k that referenced this issue Mar 13, 2024
Enabling the feature via Camel Quarkus way.

Closes apache#4048
squakez added a commit to squakez/camel-k that referenced this issue Mar 14, 2024
Enabling the feature via Camel Quarkus way.

Closes apache#4048
squakez added a commit to squakez/camel-k that referenced this issue Mar 21, 2024
Delegate to the catalog all configuration required to run the trait

Closes apache#4048
squakez added a commit to squakez/camel-k that referenced this issue Mar 22, 2024
squakez added a commit to squakez/camel-k that referenced this issue Apr 1, 2024
squakez added a commit that referenced this issue Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment