Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default value in a specific field for trait properties in CRD #4726

Closed
apupier opened this issue Sep 7, 2023 · 5 comments
Closed

Provide default value in a specific field for trait properties in CRD #4726

apupier opened this issue Sep 7, 2023 · 5 comments
Labels
kind/feature New feature or request status/stale

Comments

@apupier
Copy link
Contributor

apupier commented Sep 7, 2023

Requirement

As a user I would like to have default value pre-filled

Problem

the default value is provided inside the description text which is not convenient to read from for tooling that want to read/display the display value more prohemitently

Proposal

No response

Open questions

No response
@apupier apupier added the kind/feature New feature or request label Sep 7, 2023
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 7, 2023
@apupier
Update to Camel K 2
cdef72a 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 7, 2023
@apupier
Update to Camel K 2
c78a72d 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Sep 7, 2023
Merged
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
3952ea2 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
4e5e8d0 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to camel-tooling/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
217dec0 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 14, 2023
@apupier
Update to Camel K 2
602a732 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Oct 10, 2023
Merged
7 tasks
@squakez squakez added this to the 2.2.0 milestone Oct 17, 2023
@gansheer
Copy link
Contributor

gansheer commented Oct 31, 2023 •
edited

@apupier Just to clarify, you are expecting the default values only for trait fields declared in the documentation to be in the CRD ? For now I plan to add only those present in the documentation.

@squakez I will take care of it.

@gansheer gansheer mentioned this issue Oct 31, 2023
Merged
@apupier
Copy link
Contributor Author

apupier commented Nov 2, 2023

you are expecting the default values only for trait fields declared in the documentation to be in the CRD ?

From Camel Language Server point of view, I identified only these ones missing. But if there are other places that are missing default values, it would be better to add them too.

@gansheer
Copy link
Contributor

gansheer commented Nov 6, 2023

I added all the default values I could find/extract. Most of the others are either given by the Kubernetes Platform implementation either conditional.
@squakez this issue is fixed AFAIK.

@squakez squakez closed this as completed Nov 6, 2023
This was referenced Jan 12, 2024
Closed
Merged
@squakez squakez reopened this Jan 17, 2024
@squakez
Copy link
Contributor

squakez commented Jan 17, 2024

We had to revert the change that fixed this issue. Still open.

@squakez squakez removed this from the 2.2.0 milestone Jan 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request status/stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apupier @gansheer @squakez