Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide full description for trait in CRD #4727

Open
apupier opened this issue Sep 7, 2023 · 4 comments
Open

Provide full description for trait in CRD #4727

apupier opened this issue Sep 7, 2023 · 4 comments
Labels
kind/feature New feature or request status/never-stale status/stale

Comments

@apupier
Copy link
Contributor

apupier commented Sep 7, 2023

Requirement

As a User
I want to have the precise description
When oen of the tooling is displying information based on the CRD

Problem

There is a precise description from here:

camel-k/resources/traits.yaml

Lines 1190 to 1194 in 922dd06

description: The platform trait is a base trait that is used to assign an integration
platform to an integration. In case the platform is missing, the trait is allowed
to create a default platform. This feature is especially useful in contexts where
there's no need to provide a custom configuration for the platform (e.g. on OpenShift
the default settings work, since there's an embedded container image registry).

but a generic one is used in the CRD:

camel-k/config/crd/bases/camel.apache.org_integrations.yaml

Line 7147 in 922dd06

description: The configuration of Platform trait

Proposal

No response

Open questions

No response
@apupier apupier added the kind/feature New feature or request label Sep 7, 2023
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 7, 2023
@apupier
Update to Camel K 2
cdef72a 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 7, 2023
@apupier
Update to Camel K 2
c78a72d 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier mentioned this issue Sep 7, 2023
Merged
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
3952ea2 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
4e5e8d0 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to camel-tooling/camel-language-server that referenced this issue Sep 12, 2023
@apupier
Update to Camel K 2
217dec0 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier added a commit to apupier/camel-language-server that referenced this issue Sep 14, 2023
@apupier
Update to Camel K 2
602a732 
It is impacting mostly the Traits completion/validation

* Embed the Camel K CRDs for now. For next iteration, it would nice to:
use one from Camel K CRD jar (or another upstream artifact) and then
also allow possibility to load from the cluster
* Requires to use Jackson Dataformat loader as Snake Yaml one is less
permissive and throwing errors
* since kubernetes client 6.2.0, no more need of a specific mock
dependency fabric8io/kubernetes-client#3924
* No more providing default values as they not yet in CRD
apache/camel-k#4726
* Some description are now a lot less precise, adapted tests and
reported apache/camel-k#4727

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@gansheer
Copy link
Contributor

gansheer commented Dec 7, 2023

I think this is still relevant.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@apupier apupier reopened this Mar 25, 2024
@apupier
Copy link
Contributor Author

apupier commented Mar 25, 2024

still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request status/never-stale status/stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apupier @gansheer