Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration naming issues with numbers in them #777

Closed
utherp0 opened this issue Jun 26, 2019 · 2 comments · Fixed by #779
Closed

Integration naming issues with numbers in them #777

utherp0 opened this issue Jun 26, 2019 · 2 comments · Fixed by #779
Assignees
Labels
kind/bug Something isn't working

Comments

@utherp0
Copy link

utherp0 commented Jun 26, 2019

If you create integrations with the same name but ending in a number the number is ignored and identical integrations are created linked to the same deployed Pod.

For example:

~/camelk/kamel run Sample.java --name=looknoeap1

Results in a deployment occurring with the name 'looknoeap'. If I then do:

~/camelk/kamel run Sample.java --name=looknoeap2

I get - integration "looknoeap" updated

For some reason the naming convention is dropping numbers at the end - it also ignores '-', i.e. --name=looknoeap-2 resolves to 'looknoeap' as well.

However, if I then do:

~/camelk/kamel run Sample.java --name=looknoeap-two

It creates an integration called 'looknoeap-two.

@jamesnetherton
Copy link
Contributor

It's because of this that any non letter characters are trimmed from the start & end of the name.

I think this is a bit too strict. IIRC Pod, Deployment & Container names validate to the DNS naming rules outlined in RFC 1123. So starting or ending the name with a numeric value should be allowed.

@utherp0
Copy link
Author

utherp0 commented Jun 27, 2019

Yup, agreed - I only found it because I have a tendency to use xxxxy for demos and noticed that one integration was created and every other test I did updated that one :-)

jamesnetherton added a commit to jamesnetherton/camel-k that referenced this issue Jun 27, 2019
@jamesnetherton jamesnetherton added the kind/bug Something isn't working label Jun 28, 2019
@jamesnetherton jamesnetherton self-assigned this Jun 28, 2019
ipolyzos pushed a commit to ipolyzos/camel-k that referenced this issue Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants