Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to push images to other registries #1084

Merged
merged 8 commits into from Nov 28, 2019
Merged

Allow to push images to other registries #1084

merged 8 commits into from Nov 28, 2019

Conversation

nicolaferraro
Copy link
Member

@nicolaferraro nicolaferraro commented Nov 23, 2019 •
edited by astefanutti

Fix #613

This enables any v2 registry to be used to host images. Works well with Docker hub. Doesn't work on Quay.io, but I'm not sure they upgraded to v2.

Still needs:

  • Documentation
  • Integration tests with other registries (there's one for docker hub that I want to try on CI)

Release Note

Added support for pushing images to authenticated external docker registries (such as Docker Hub or Github Packages)

@nicolaferraro nicolaferraro added the status/wip Work in progress label Nov 23, 2019
@nicolaferraro nicolaferraro removed the status/wip Work in progress label Nov 26, 2019
@nicolaferraro
Copy link
Member Author

nicolaferraro commented Nov 26, 2019 •
edited

Removing WIP.

I've:

  • Added documentation on how to configure an external registry
  • Included examples about docker hub and github packages
  • Added integration tests for both (with credentials setup on Travis)
  • Added a new trait (pull-secret trait) for configuring automatically the pull secret for an integration, so that private external registries can be used without issues (Github packages is private for pull)
  • Upgraded Kaniko to 0.14.0 to see if it solves other issues

@astefanutti astefanutti merged commit 46fa770 into apache:master Nov 28, 2019
@nicolaferraro nicolaferraro mentioned this pull request Nov 29, 2019
Closed
@nicolaferraro nicolaferraro mentioned this pull request Dec 20, 2019
Closed
@dylanenabled dylanenabled mentioned this pull request Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefanutti astefanutti astefanutti approved these changes

@lburgazzoli lburgazzoli Awaiting requested review from lburgazzoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kaniko: Add ability to push to on-premise registries
2 participants
@nicolaferraro @astefanutti