Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AWS ECR in kaniko builder in Operator #1031

Closed
dylanenabled opened this issue Oct 30, 2019 · 9 comments
Closed

Support for AWS ECR in kaniko builder in Operator #1031

dylanenabled opened this issue Oct 30, 2019 · 9 comments
Labels
area/build-operator Related to the internal image build operator kind/feature New feature or request status/stale

Comments

@dylanenabled
Copy link

dylanenabled commented Oct 30, 2019

Currently the kaniko builder only supports pushing images to Google.

I'd like it if kaniko could push builds to AWS ECR. It looks like this is fairly straightforward to implement in the kaniko image as described in the documentation.

It looks like being able to define a --registryDockerConfig parameter when installing the platform (via kamel install) would work. This could save a provided docker config.json to a configmap, and then mounts it at /kaniko/.docker in the build image, similar to how the kaniko secret is saved.

The aws account credentials could be saved similarly to how it is done for GCR. instead mounted to /root/.aws. This could be optional however because the IAM credentials could also be provided to the builder by EKS via the IAM integration using the camel-k-builder serviceaccount if the cluster has that set up (see #1030).

More generically I guess, some way of defining secret and configmap mounts for the builder containers would also work.

@dylanenabled dylanenabled changed the title Support for AWS ECR in kaniko builder Support for AWS ECR in kaniko builder in Operator Oct 30, 2019
@astefanutti astefanutti added the area/build-operator Related to the internal image build operator label Feb 11, 2020
@dylanenabled
Copy link
Author

dylanenabled commented Feb 13, 2020

Looks like #1084 implements this?

EDIT: looks like it still needs a way of either setting the builder pod's serviceaccount (the preferred method, related to #1030 but for builders) or otherwise mounting an AWS secret file into the builder container at /root/.aws/credentials in order to work.

@lburgazzoli lburgazzoli added target/aws kind/feature New feature or request labels Jun 5, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@Richardmbs12
Copy link

Richardmbs12 commented Apr 23, 2022

Any news on this? This will be highly valuable and enable a lot of AWS EKS/ECR users to use camelk

@squakez
Copy link
Contributor

squakez commented Apr 25, 2022

We have no documentation related to that platform unfortunately. Contributions are very welcome.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@Richardmbs12
Copy link

Had to move to normal camel 🙁

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@kjozsa
Copy link

kjozsa commented Oct 29, 2022

I'd also like to see ECR being officially supported with Camel K.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-operator Related to the internal image build operator kind/feature New feature or request status/stale
Projects
None yet
Development

No branches or pull requests

6 participants