Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tekton parameters with parentheses instead of curly brackets #1272

Merged
merged 3 commits into from Feb 12, 2020

Conversation

brunoNetId
Copy link
Contributor

@brunoNetId brunoNetId commented Feb 12, 2020

I've tested this tutorial using OpenShift v4.2 and the Pipelines Operator v0.8.2.
It fails as is, it appears parameters with curly brackets do not work.
Using parentheses it works.

Mind this is the documentation page, which also makes reference to the source file:

  • camel-k-pipeline-task-definition.yaml
    I don't know where that file is located, but also would need to be updated to replace '{ }' with '( )'.

Mind this is the documentation page, which also makes reference to the source file:

  • camel-k-pipeline-task-definition.yaml
    I don't know where that file is located, but also would need to be updated to replace '{ }' with '( )'.

Release Note


brunoNetId and others added 2 commits February 12, 2020 09:40
I've tested this tutorial using OpenShift v4.2 and the Pipelines Operator v0.8.2.
It fails as is, it appears parameters with curly brackets do not work.
Using parentheses it works.

Mind this is the documentation page, which also makes reference to the source file:
 - camel-k-pipeline-task-definition.yaml
I don't know where that file is located, but also would need to be updated to replace '{ }' with '( )'.
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating it, I've edited the file you mentioned.

docs/modules/ROOT/pages/tutorials/tekton/tekton.adoc Outdated Show resolved Hide resolved
remove TIP as default is now with parentheses

Co-Authored-By: Nicola Ferraro <ni.ferraro@gmail.com>
@nicolaferraro nicolaferraro merged commit 453aff5 into apache:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants