Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tekton parameters with parentheses instead of curly brackets #1272

Merged
merged 3 commits into from Feb 12, 2020
Merged

tekton parameters with parentheses instead of curly brackets #1272

merged 3 commits into from Feb 12, 2020

Commits on Feb 12, 2020

  1. Parentheses instead of curly brackets 

    I've tested this tutorial using OpenShift v4.2 and the Pipelines Operator v0.8.2.
It fails as is, it appears parameters with curly brackets do not work.
Using parentheses it works.

Mind this is the documentation page, which also makes reference to the source file:
 - camel-k-pipeline-task-definition.yaml
I don't know where that file is located, but also would need to be updated to replace '{ }' with '( )'.
    @brunoNetId
    brunoNetId committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    1768f59 View commit details
    Browse the repository at this point in the history

  2. This should be changed as well

    @nicolaferraro
    nicolaferraro committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    a36d63b View commit details
    Browse the repository at this point in the history

  3. Update docs/modules/ROOT/pages/tutorials/tekton/tekton.adoc 

    remove TIP as default is now with parentheses

Co-Authored-By: Nicola Ferraro <ni.ferraro@gmail.com>
    @brunoNetId @nicolaferraro
    brunoNetId and nicolaferraro committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    c43cffc View commit details
    Browse the repository at this point in the history