Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1449: add support for modeline options #1455

Merged
merged 6 commits into from
May 11, 2020
Merged

Fix #1449: add support for modeline options #1455

merged 6 commits into from
May 11, 2020

Conversation

nicolaferraro
Copy link
Member

@nicolaferraro nicolaferraro commented May 7, 2020 •
edited
Loading

Given:

file.groovy

// camel-k: dependency=org.my:app:1.0

from("...").to("...")

Now kamel run file.groovy is equivalent to the old kamel run file.groovy --dependency=org.my:app:1.0.

The full command is always printed in the CLI logs.

How does it look?

Release Note

Modeline options can now be used to specify CLI flags directly in source files

@nicolaferraro nicolaferraro added status/wip Work in progress kind/feature New feature or request and removed status/wip Work in progress labels May 7, 2020
@nicolaferraro nicolaferraro marked this pull request as ready for review May 8, 2020 10:57
@nicolaferraro nicolaferraro merged commit 4b5f215 into apache:master May 11, 2020
@nicolaferraro nicolaferraro mentioned this pull request Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nicolaferraro @oscerd