-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1556 - Add the camel category to Camel K CRDs #1615
#1556 - Add the camel category to Camel K CRDs #1615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following #1582, the CRDs are generated from the APIs. Could you declare the categories in the types using // +kubebuilder:resource:categories=<[]string>
, as documented in https://book.kubebuilder.io/reference/markers/crd.html.
Also, could you confirm categories are supported by apiextensions.k8s.io/v1beta1
?
e160833
to
9ba54c8
Compare
@astefanutti thanks for the review. I have appended the code to generate Also, I could confirm that categories are supported by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Categories must be appended in the existing marker, e.g.:
// +kubebuilder:resource:path=integrations,scope=Namespaced,shortName=it,categories=kamel;camel
Otherwise, the generation tool just takes the latest one.
You can test by running make generate-crd
.
9ba54c8
to
1e885a5
Compare
Thank you for the advice, I have applied the change and the tests seems to work fine. Please see below for the test run:
|
1e885a5
to
b4e7cbf
Compare
b4e7cbf
to
cca508d
Compare
cca508d
to
486e0ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Added 'kamel' & 'camel' categories to Camel-K CRDs (i.e Build, CamelCatalog, Integration, IntegrationKit)
Please see below example usage: