-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(doc): broken links #2282
fix(doc): broken links #2282
Conversation
* Excluded a private struct so it's no longer linked in the gen docs * Workaround an issue reported to convert urlencoded chars Fixes apache#2280
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for review. Feel free to merge it so we can see if the Camel Doc Build is happy now. |
The website it is still failing: https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/85/console @squakez @astefanutti |
Thanks @oscerd. What would be the suggested way to run those checks locally? I'd prefer to fix them all before submitting next PR. |
There is no easy way of doing this directly, I guess you may need to commit something here on camel-k repo and then run the website full build but @zregvart knows this better than myself. |
I'm going to exclude these pages from the checks, for that I need to upgrade the |
Thanks @zregvart. I've included those checks in the camel k as well, so we can use to validate the subproject as well. The error I am getting are not exactly the same, but they should be enough to have an idea on what it will be failing on camel website. This is the PR. If you've already skipped those checks, you may want to revert the one on |
Upgrades cargo-deadlinks to 0.8.0[1], currently latest version. A previous version included a fix that might help with URL encoded anchors present in camel-k API documentation[2][3] [1] https://github.com/deadlinks/cargo-deadlinks/blob/master/CHANGELOG.md [2] deadlinks/cargo-deadlinks#139 [3] apache/camel-k#2282
With apache/camel-website@07c4c3f this workaround might not be needed any more. |
Fixes #2280
Release Note