Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): broken links #2282

Merged
merged 1 commit into from May 11, 2021
Merged

fix(doc): broken links #2282

merged 1 commit into from May 11, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented May 11, 2021

  • Excluded a private struct so it's no longer linked in the gen docs
  • Workaround an issue reported to convert urlencoded chars

Fixes #2280

Release Note

NONE

* Excluded a private struct so it's no longer linked in the gen docs
* Workaround an issue reported to convert urlencoded chars

Fixes apache#2280
@squakez
Copy link
Contributor Author

squakez commented May 11, 2021

cc @astefanutti @zregvart

Copy link
Member

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@squakez
Copy link
Contributor Author

squakez commented May 11, 2021

Thanks for review. Feel free to merge it so we can see if the Camel Doc Build is happy now.

@oscerd oscerd merged commit aead3fa into apache:main May 11, 2021
@oscerd
Copy link
Contributor

oscerd commented May 12, 2021

@squakez
Copy link
Contributor Author

squakez commented May 12, 2021

The website it is still failing: https://ci-builds.apache.org/job/Camel/job/Camel.website/job/main/85/console @squakez @astefanutti

Thanks @oscerd. What would be the suggested way to run those checks locally? I'd prefer to fix them all before submitting next PR.

@oscerd
Copy link
Contributor

oscerd commented May 12, 2021

There is no easy way of doing this directly, I guess you may need to commit something here on camel-k repo and then run the website full build but @zregvart knows this better than myself.

@zregvart
Copy link
Member

I'm going to exclude these pages from the checks, for that I need to upgrade the html-validate dependency and fix any issues new rules bring as ignoring certain files is a feature of the newer version. Checks can be run by running yarn checks, best after a production build by doing CAMEL_ENV=production yarn build-all. Some of this is explained in the https://github.com/apache/camel-website/ README.

@squakez
Copy link
Contributor Author

squakez commented May 12, 2021

Thanks @zregvart. I've included those checks in the camel k as well, so we can use to validate the subproject as well. The error I am getting are not exactly the same, but they should be enough to have an idea on what it will be failing on camel website. This is the PR.

If you've already skipped those checks, you may want to revert the one on public/camel-k/latest/apis/camel.html file. The other one failing (public/camel-k/latest/apis/crds-html.html) is something that could not be easily fixed, so we must skip that. However it should be not an issue as the page is just used for inclusion purposes.

zregvart added a commit to apache/camel-website that referenced this pull request May 17, 2021
Upgrades cargo-deadlinks to 0.8.0[1], currently latest version. A
previous version included a fix that might help with URL encoded anchors
present in camel-k API documentation[2][3]

[1] https://github.com/deadlinks/cargo-deadlinks/blob/master/CHANGELOG.md
[2] deadlinks/cargo-deadlinks#139
[3] apache/camel-k#2282
@zregvart
Copy link
Member

With apache/camel-website@07c4c3f this workaround might not be needed any more.

@nicolaferraro nicolaferraro mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Broken links on autogenerated API
4 participants