feat(cli): make kamel delete command aware of KameletBindings #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
May 27, 2021
davsclaus
approved these changes
May 27, 2021
nicolaferraro
requested changes
May 27, 2021
| fmt.Println("KameletBinding " + binding + " deleted") | ||
| return nil | ||
| } | ||
| return c.Delete(ctx, integration) |
There was a problem hiding this comment.
Can you skip this when the KameletBinding is deleted? Deletion of integration is done in cascade, otherwise there might be temporary recreations.
There was a problem hiding this comment.
Actually, the code already relies on the cascading delete. In this code, when the KameletBinding is deleted it early returns in the previous block so c.Delete(ctx, integration) won't be executed. Isn't it what you suggest?
tadayosi
force-pushed
the
Issue-2305-delete-klb
branch
from
3ea3b6f
to
642a295
Compare
Kamelet Binding controller now attaches "created.by" labels to integrations which a kamelet binding creates, and `kamel delete` uses these labels to identify bindings to delete together if there is any. Fix apache#2305
tadayosi
force-pushed
the
Issue-2305-delete-klb
branch
from
642a295
to
86618ba
Compare
|
@nicolaferraro Changed. Can you have a look? Thanks! |
nicolaferraro
approved these changes
Jun 1, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kamelet Binding controller now attaches "created.by" labels to integrations which a kamelet binding creates, and
kamel deleteuses these labels to identify bindings to delete together if there is any.
Fix #2305