Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kamel delete should consider KameletBindings #2305

Closed
nicolaferraro opened this issue May 17, 2021 · 1 comment · Fixed by #2332
Closed

Kamel delete should consider KameletBindings #2305

nicolaferraro opened this issue May 17, 2021 · 1 comment · Fixed by #2332
Assignees
@tadayosi
Milestone
1.5.0

Comments

@nicolaferraro
Copy link
Member

Otherwise, if it only cancels the integration, then it's recreated. I think it happens in the VS code tooling.
@nicolaferraro nicolaferraro added this to the 1.5.0 milestone May 17, 2021
@tadayosi
Copy link
Member

Let me look into it.

@tadayosi tadayosi self-assigned this May 19, 2021
tadayosi added a commit to tadayosi/camel-k that referenced this issue May 27, 2021
@tadayosi
feat(cli): make kamel delete command aware of KameletBindings
3ea3b6f 
Kamelet Binding controller now attaches "created.by" labels to
integrations which a kamelet binding creates, and `kamel delete`
uses these labels to identify bindings to delete together if there is
any.

Fix apache#2305
@tadayosi tadayosi mentioned this issue May 27, 2021
Merged
tadayosi added a commit to tadayosi/camel-k that referenced this issue May 31, 2021
@tadayosi
feat(cli): make kamel delete command aware of KameletBindings
642a295 
Kamelet Binding controller now attaches "created.by" labels to
integrations which a kamelet binding creates, and `kamel delete`
uses these labels to identify bindings to delete together if there is
any.

Fix apache#2305
tadayosi added a commit to tadayosi/camel-k that referenced this issue May 31, 2021
@tadayosi
feat(cli): make kamel delete command aware of KameletBindings
86618ba 
Kamelet Binding controller now attaches "created.by" labels to
integrations which a kamelet binding creates, and `kamel delete`
uses these labels to identify bindings to delete together if there is
any.

Fix apache#2305
nicolaferraro pushed a commit that referenced this issue Jun 1, 2021
@tadayosi @nicolaferraro
feat(cli): make kamel delete command aware of KameletBindings
0e2423f 
Kamelet Binding controller now attaches "created.by" labels to
integrations which a kamelet binding creates, and `kamel delete`
uses these labels to identify bindings to delete together if there is
any.

Fix #2305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadayosi tadayosi

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

feat(cli): make kamel delete command aware of KameletBindings tadayosi/camel-k
2 participants
@tadayosi @nicolaferraro