initial support for custom maven repositories #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Nov 23, 2018
lburgazzoli
force-pushed
the
maven-repo
branch
from
d3135fc
to
1278fde
Compare
nicolaferraro
requested changes
Nov 24, 2018
| @@ -56,6 +56,7 @@ type IntegrationSpec struct { | |||
| Profile TraitProfile `json:"profile,omitempty"` | |||
| Traits map[string]IntegrationTraitSpec `json:"traits,omitempty"` | |||
| Configuration []ConfigurationSpec `json:"configuration,omitempty"` | |||
| Repositories []string `json:"repositories,omitempty"` | |||
There was a problem hiding this comment.
I think it's important to set this at Integration level as you did, but it's more to support snippets in the future... I'd put it also at IntegrationPlatform level, so that one can specify repositories for the global installation.
And the one at integration level overrides the one at platform level. I'm not sure about context level repo.
There was a problem hiding this comment.
Yes but the whole platform configuration is another and wider topic so I left it for future development :)
nicolaferraro
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.