-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Missing cli e2e tests implementation #2461
Conversation
I think the test spotted an hidden issue:
Probably the |
Should be rebased after #2496 is merged. |
Please @vsokolov00, rebase this PR to see if now the test pass correctly. |
@squakez pr is ready to merge! :) |
@vsokolov00 could you please run |
Empty output @astefanutti |
@vsokolov00 when I run for example func GetOutputStringAsync(cmd *cobra.Command) func() string {
var buffer bytes.Buffer
stdout := bufio.NewWriter(&buffer)
cmd.SetOut(stdout)
go cmd.Execute()
return func() string {
return buffer.String()
}
} compared to: func GetOutputStringAsync(cmd *cobra.Command) func () string {
var buffer bytes.Buffer
stdout := bufio.NewWriter(&buffer)
cmd.SetOut(stdout)
go cmd.Execute()
return func () string{
return buffer.String()
}
} I think |
You are right, it should be executed over the whole packages (also it automatically edits problem code) @astefanutti |
PR for:
https://issues.redhat.com/browse/FUSEQE-13290
https://issues.redhat.com/browse/FUSEQE-13294