Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): OLM default discovery #2735

Merged
merged 1 commit into from
Nov 11, 2021
Merged

feat(cmd): OLM default discovery #2735

merged 1 commit into from
Nov 11, 2021

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Nov 8, 2021

If the cluster which we are connected is a plain K8S cluster, we will use Operator SDK community parameters during OLM installation procedure.

With this PR we're discovering the cluster type dynamically and provide the proper OLM configuration during install/uninstall phase.

Closes #2113

Release Note

feat(cmd): OLM default discovery

If the cluster which we are connected is a plain K8S cluster, we will use Operator SDK community parameters during OLM installation procedure.

Closes apache#2113
@squakez
Copy link
Contributor Author

squakez commented Nov 10, 2021

The E2E are failing because:

    --- FAIL: TestMetrics/reconciliation_duration_metric (0.04s)

not related to this PR and reported in #2742. I am going to merge if there is no objection.

@squakez squakez merged commit 8f6a997 into apache:main Nov 11, 2021
@squakez squakez deleted the feat/2113 branch November 11, 2021 08:41
@oscerd oscerd mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OLM installation may fail with default values
4 participants