-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local dependencies #2835
Local dependencies #2835
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor findings.
@@ -18,17 +18,20 @@ limitations under the License. | |||
package cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
c0dcc85
to
b6d03a0
Compare
Ok I think it's ready to be reviewed! The test failure seem unrelated. Feel free to comment on the wagon behavior as well if needed. To be compliant with various Registry vendors, we map Maven artifacts to Image names by: lower casing it's HTTP path, prefixed with
Artifacts stored in the Image Registry that are to be mounted in the running container use the URI: Let me know what you think! Thanks ! |
b6d03a0
to
9e5deed
Compare
By the way let me know if I can do anything to help with the review, or if this PR is a bad idea in the first place :) |
9e5deed
to
3d5c1b5
Compare
…d in the running container
…arent directory
…'s CA and Authentication with Maven when using the Image Registry as a Maven Registry
3d5c1b5
to
3c5ba76
Compare
rebased from main branch @astefanutti @lburgazzoli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Maybe we need to provide some detailed example as a follow up activity, but good to merge for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnpoth awesome work. Sorry for the late review, I've left a couple of comments / questions.
No worries @astefanutti ! Always nice to read your thoughtful comments! I can address these in a follow up PR no problem |
Requires container-tools/spectrum#7 and a few enhancements but the core is here :)
Thanks !
Closes #1227
Release Note