Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): Account for requeued and errored integration reconciliations #2836

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix(e2e): Account for requeued and errored integration reconciliations #2836

merged 1 commit into from
Dec 15, 2021

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Dec 15, 2021 •
edited
Loading

Follows up #2833 that highlighted another issue to fix #2742.

Release Note

NONE

This was referenced Dec 15, 2021
Merged
Merged
@astefanutti
Copy link
Member Author

Let me merge this as the metrics test passes on both Kubernetes and OpenShift:

--- PASS: TestMetrics (82.89s)
    --- PASS: TestMetrics/Build_duration_metric (0.02s)
    --- PASS: TestMetrics/Build_recovery_attempts_metric (0.03s)
    --- PASS: TestMetrics/reconciliation_duration_metric (0.11s)
    --- PASS: TestMetrics/Build_queue_duration_metric (0.03s)
    --- PASS: TestMetrics/Integration_first_readiness_metric (0.03s)

@astefanutti astefanutti merged commit 9cf6c60 into apache:main Dec 15, 2021
@astefanutti astefanutti deleted the pr-357 branch December 15, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[E2E] Reconciliation duration metric failure
3 participants
@astefanutti @oscerd @squakez