Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): Avoid nested Gomega fields matcher #2833

Merged
merged 2 commits into from
Dec 15, 2021
Merged

fix(e2e): Avoid nested Gomega fields matcher #2833

merged 2 commits into from
Dec 15, 2021

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Dec 14, 2021

Fixes #2742.

Release Note

fix(e2e): Avoid nested Gomega fields matcher

@astefanutti astefanutti changed the title fix(e2e): Avoid nested Gomega nested fields matcher fix(e2e): Avoid nested Gomega fields matcher Dec 14, 2021
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this has better luck than the experiments I'm running. However, I see that the comparison done is the same.

@astefanutti
Copy link
Member Author

Hope this has better luck than the experiments I'm running. However, I see that the comparison done is the same.

"Once you eliminate the impossible, whatever remains, no matter how improbable, must be the truth."

@squakez
Copy link
Contributor

squakez commented Dec 15, 2021

Unfortunately, this still fails: https://github.com/apache/camel-k/runs/4532928843?check_suite_focus=true

 === RUN   TestMetrics/reconciliation_duration_metric
    operator_metrics_test.go:272: 
        Expected
            <uint>: 12
        to be ==
            <uint64>: 11

It's the same pattern I've observed lately. Sometimes it fail with the metrics having +1 sample counted. I've collected traces to see if the counter is called more than expected, and it did not happen. Either the sum of the metrics is not calculated correctly, or there is some hidden call to the metrics reconcile which create that additional sample. What I managed to see is that most of the time it happens when one of the reconciliation takes long (more than 30 seconds), altough, also in that case I cannot log any further execution that the ones expected.

@astefanutti
Copy link
Member Author

That's an additional issue, that's hopefully fixed with #2836.

@squakez
Copy link
Contributor

squakez commented Dec 15, 2021

That's an additional issue, that's hopefully fixed with #2836.

Those requeued may be the reason, altough I never managed to capture a trace of them during my experiments. Let's see how it goes. 🤞

@oscerd oscerd mentioned this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E] Reconciliation duration metric failure
3 participants