Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gc): Skip GC for first integration generation #3327

Merged
merged 1 commit into from
Jun 2, 2022
Merged

feat(gc): Skip GC for first integration generation #3327

merged 1 commit into from
Jun 2, 2022

Conversation

astefanutti
Copy link
Member

The GC trait relies on the generation metadata field of the integration, by propagating it to owned resources in a label, and listing the laters with label selection using the < selector operator. Assuming the generation field is a monotonically increasing strictly positive integer, it's safe to skip garbage collection on the first integration generation, i.e., when the generation field is less or equal to one, to reduce the overhead on the API server.

Release Note

feat(gc): Skip GC for first integration generation

@astefanutti astefanutti added the kind/feature New feature or request label Jun 2, 2022
@astefanutti astefanutti merged commit 0dd6d8c into apache:main Jun 2, 2022
@astefanutti astefanutti deleted the pr-421 branch June 2, 2022 12:04
@squakez
Copy link
Contributor

squakez commented Jun 2, 2022

I think we should backport (this and the previous gc related one).

@christophd
Copy link
Contributor

I will run some performance tests tomorrow with the fix and verify. once the fix is confirmed we can backport, ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants