Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ci build rule and license fix #3333

Merged
merged 1 commit into from
Jun 7, 2022
Merged

chore: ci build rule and license fix #3333

merged 1 commit into from
Jun 7, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Jun 3, 2022

Release Note

NONE

@squakez squakez marked this pull request as ready for review June 3, 2022 07:42
@squakez
Copy link
Contributor Author

squakez commented Jun 3, 2022

FYI @phantomjinx

tadayosi
tadayosi reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets wait for @phantomjinx to review it.

phantomjinx
phantomjinx approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@squakez squakez merged commit 87d9d7a into apache:main Jun 7, 2022
@squakez squakez deleted the chore/ci_build branch June 7, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi left review comments

@phantomjinx phantomjinx phantomjinx approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@squakez @tadayosi @phantomjinx @oscerd