fix(#3390): Fix Knative addressable resolver cluster role binding #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefanutti
reviewed
Jun 27, 2022
christophd
force-pushed
the
issue/3390/rbac-addressable-resolver
branch
from
e012690
to
191867a
Compare
|
@astefanutti could you please have another look. I am now only using the operatorNamespace passing in the globalOperator boolean flag to see if we need to set as cluster role or normal role binding. This way we avoid having two namespaces (WATCH_NAMESPACE and operatorNamespace) in the funcs and it will be less confusing |
astefanutti
reviewed
Jun 30, 2022
…ng in global operator mode Use proper operator namespace in the service account role binding subject for global operators. Was using empty global operator watch namespace before which caused errors in the cluster role binding.
christophd
force-pushed
the
issue/3390/rbac-addressable-resolver
branch
from
191867a
to
274f712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper operator namespace in the service account role binding subject for global operators. Was using empty global operator watch namespace which caused errors in the cluster role binding.
Fixes #3390
Fixes #3328
Closes #3391
Release Note