Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trait): Camel trait as IntegrationKit #3788

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix(trait): Camel trait as IntegrationKit #3788

merged 2 commits into from
Nov 2, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Oct 31, 2022

Closes #3758

Release Note

fix(trait): Camel trait as IntegrationKit

@squakez squakez added the kind/bug Something isn't working label Oct 31, 2022
tadayosi
tadayosi reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick but otherwise LGTM.

pkg/apis/camel/v1/integrationkit_types.go Outdated Show resolved Hide resolved
pkg/trait/trait_test.go Outdated Show resolved Hide resolved
@tadayosi tadayosi added this to the 1.11.0 milestone Nov 1, 2022
@squakez squakez merged commit 31d4482 into apache:main Nov 2, 2022
@squakez squakez deleted the fix/3758 branch November 2, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi left review comments

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Runtime trait failure
3 participants
@squakez @tadayosi @oscerd