fix(service): Create k8s service when knative-service trait is disabled #3871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squakez
reviewed
Dec 2, 2022
There was a problem hiding this comment.
I've reviewed the backport one (in the future, I'd prefer we wait to provide a backport PR until the main one has been approved/discussed). They are the same consideration for this #3870 (review)
|
uff, that confused me as well. I also added some review comments to the backport PR. Funnily enough the comments are quite the same as here 😄 |
Oh, that's not good from my PR, I did this in a hurry. Good reminder for next PR. |
claudio4j
force-pushed
the
fix_knativeservice_main
branch
from
0756354
to
f4c8fd0
Compare
squakez
approved these changes
Dec 2, 2022
|
/retest |
tadayosi
requested changes
Dec 4, 2022
…abled apache#3849 When knative-service and k8s service traits are enabled, the priority is to use knative-service in knative profile
claudio4j
force-pushed
the
fix_knativeservice_main
branch
from
f4c8fd0
to
18f7317
Compare
tadayosi
approved these changes
Dec 5, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3849
When knative-service and k8s service traits are enabled, the priority is to use knative-service in knative profile
Release Note