-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(service): Create k8s service when knative-service trait is disabled (1.10.x) #3870
fix(service): Create k8s service when knative-service trait is disabled (1.10.x) #3870
Conversation
@christophd for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Found two minor things and the validate job complains about comments formatting.
Thanks Claudio, especially for the excellent test coverage!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it could be fine. However there are some consideration I'd like you to ponder before merging.
cc72674
to
0a69736
Compare
…abled apache#3849 When knative-service and k8s service traits are enabled, the priority is to use knative-service in knative profile
0a69736
to
320f21f
Compare
fix(service): Create k8s service when knative-service trait is disabled (1.10.x)
fix(service): Create k8s service when knative-service trait is disabled (1.10.x) Conflict fixed manually (cherry picked from commit apache/camel-k@ff92034e4)
#3849
When knative-service and k8s service traits are enabled, the priority is to use knative-service in knative profile
(cherry picked from commit 0756354)
Release Note