Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Generate apply configurations #3968

Merged
merged 4 commits into from
Jan 10, 2023
Merged

api: Generate apply configurations #3968

merged 4 commits into from
Jan 10, 2023

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Jan 9, 2023

This PR adds the apply configurations to the generated Camel K client so that API types can be used with server-side apply.

The generation requires kubernetes/kubernetes#114920 to be fully functional, but the configuration can readily be used.

Release Note

api: Generate apply configurations

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if it makes sense, but, if this kind of code is autogenerated, I think it could be added to the automatic nightly update we have enabled recently: https://github.com/apache/camel-k/blob/main/.github/actions/automatic-updates/action.yml

@astefanutti
Copy link
Member Author

I am not sure if it makes sense, but, if this kind of code is autogenerated, I think it could be added to the automatic nightly update we have enabled recently: https://github.com/apache/camel-k/blob/main/.github/actions/automatic-updates/action.yml

Yes, it'll be updated as part of the make generate call.

@astefanutti astefanutti merged commit b5e2089 into apache:main Jan 10, 2023
@astefanutti astefanutti deleted the pr-440 branch January 10, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants