Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3476) Add tests for enabling traits at IntegrationPlatform #4232

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Apr 5, 2023

Release Note

NONE

@squakez squakez linked an issue Apr 5, 2023 that may be closed by this pull request
@bouskaJ bouskaJ force-pushed the integration_platform_traits branch 2 times, most recently from 6e18105 to e803f34 Compare April 11, 2023 12:35
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this test needs to go under the commonwithcustominstall suite, as it would change a common resource used by other tests. See https://camel.apache.org/camel-k/next/contributing/e2e.html#testing-e2e-structure

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Apr 11, 2023

I think this test needs to go under the commonwithcustominstall suite, as it would change a common resource used by other tests. See https://camel.apache.org/camel-k/next/contributing/e2e.html#testing-e2e-structure

yes, I wanted to avoid the commonwithcustominstall to make the test more universal but I did not know that multiple tests run in the same namespace. I will move it.

@bouskaJ bouskaJ force-pushed the integration_platform_traits branch from e803f34 to c2f4d91 Compare April 12, 2023 11:26
@bouskaJ
Copy link
Contributor Author

bouskaJ commented Apr 24, 2023

It seems that this PR fails on non-related tests. Can you rerun the CI?

❌ TestKamelCLIRun (13.87s)
❌ TestKamelCLIRun/Examples_from_GitHub (13.87s)
❌ TestKamelCLIRun/Examples_from_GitHub/Gist_(ID) (60ms)
❌ TestKamelReset (0s)
❌ TestKamelReset/Reset_skip-integrations (0s)
❌ TestKamelReset/Reset_skip-kits (0s)
❌ TestKamelReset/Reset_the_whole_platform (0s)

The new test passed

✅ TestTraitOnIntegrationPlatform (3m21.6s)
✅ TestTraitOnIntegrationPlatform/Run_integration_with_platform_traits (3m14.48s)

@squakez squakez merged commit 621b929 into apache:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E] Add tests for enabling traits at IntegrationPlatform
2 participants