Ability to customise the generated camel-k image #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
reviewed
Feb 14, 2019
contributing.adoc
Outdated
| The above command produces a `camel-k` image with name `docker.io/apache/camel-k`. Sometimes you might need to produce camel-k images that need to be pushed to the custom repository e.g. `docker.io/myrepo/camel-k`, to do that you can pass a parameter `imgDestination` to the make as shown below: | ||
|
|
||
| ``` | ||
| make imgDestination='docker.io/myrepo' images |
There was a problem hiding this comment.
would prefer to have the variable name uppercase
There was a problem hiding this comment.
but traditionally the make variables are passed as camelCased ones; anyways will have it updated
There was a problem hiding this comment.
yeah, sorry I was thinking that this could be a generic env var
There was a problem hiding this comment.
so I leave it as it is?
There was a problem hiding this comment.
yes for the moment, can you fix the conflicts ?
There was a problem hiding this comment.
fixed them. dont know how it seeped in IIRC i merged them ;)
kameshsampath
force-pushed
the
issue-437
branch
from
a11d767
to
4a1e067
Compare
kameshsampath
force-pushed
the
issue-437
branch
from
4a1e067
to
c9c803c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving Issue #437