573 allow to add remove elements from catalog dynamically through api #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a best practice recommended by Sonar. The public modifier was mandatory with Junit4, it is no more the case with JUnit 5. Signed-off-by: Aurélien Pupier <apupier@redhat.com>
- removed getConnectorAsJson from public API . I'm not sure that it is very useful now that we can have the Java model and add a connector. it is also simplifying the API to add a connector Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
573-AllowToAddremoveElementsFromCatalogDynamicallyThroughAPI
branch
from
48f86a8
to
bb5437c
Compare
Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
573-AllowToAddremoveElementsFromCatalogDynamicallyThroughAPI
branch
from
bb5437c
to
2b2123f
Compare
oscerd
reviewed
Oct 12, 2020
...atalog/src/main/java/org/apache/camel/kafkaconnector/catalog/CamelKafkaConnectorCatalog.java
Show resolved
Hide resolved
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
Please don't import with * operator
There was a problem hiding this comment.
I was only using the defaults of Eclipse projects but fine to follow another rule.
even for JUnit assertions Signed-off-by: Aurélien Pupier <apupier@redhat.com>
|
LGTM. Let me merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.