Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial source code - Add license headers #4

Closed
davsclaus opened this issue Jun 27, 2019 · 5 comments · Fixed by #22
Closed

Initial source code - Add license headers #4

davsclaus opened this issue Jun 27, 2019 · 5 comments · Fixed by #22
Assignees
@lburgazzoli

Comments

@davsclaus
Copy link
Contributor

The source code should have ASF license headers in java / xml files etc, just like Apache Camel project
@ppalaga
Copy link
Contributor

ppalaga commented Jul 1, 2019

You mean the headers should be changed also in files coming from the Quarkus repo? I have Thou shall not change license/copyright/authors headers when copying third party code stored somewhere deep in my brain. What would be the legal reasoning to break this rule?

@davsclaus
Copy link
Contributor Author

Yes after the initial port we should migrate it to have ASF license headers and packaging name and so on.

We cannot accept source code that is not ASF license header. And the code donation is where you give over the code to ASF

@lburgazzoli lburgazzoli assigned ppalaga and lburgazzoli and unassigned ppalaga Jul 1, 2019
@lburgazzoli
Copy link
Contributor

@ppalaga I'm taking it as I'm working to something related

@ppalaga
Copy link
Contributor

ppalaga commented Jul 2, 2019

I'm taking it as I'm working to something related

No problem, just note that I am in the process of refactoring the package names and it would be hard for me solve any conflicts.

lburgazzoli added a commit to lburgazzoli/apache-camel-quarkus that referenced this issue Jul 2, 2019
@lburgazzoli
Initial source code - Add license headers apache#4
89455b2
@lburgazzoli
Copy link
Contributor

lburgazzoli commented Jul 2, 2019 •
edited
Loading

See #22

@lburgazzoli lburgazzoli mentioned this issue Jul 2, 2019
Merged
lburgazzoli added a commit to lburgazzoli/apache-camel-quarkus that referenced this issue Jul 2, 2019
@lburgazzoli
Initial source code - Add license headers apache#4
55eb40a
@oscerd oscerd closed this as completed in #22 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lburgazzoli lburgazzoli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial import cleanup lburgazzoli/apache-camel-quarkus
3 participants
@davsclaus @ppalaga @lburgazzoli