core: sync BaseModel and FastCamelContext with Camel main #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
requested review from
davsclaus,
jamesnetherton and
ppalaga
and removed request for
davsclaus and
jamesnetherton
|
@ppalaga @jamesnetherton more tests may be required, this is the bare minimum I got with the time I had today. |
nicolaferraro
approved these changes
Jun 8, 2021
oscerd
approved these changes
Jun 8, 2021
davsclaus
approved these changes
Jun 9, 2021
...n-tests/kamelet/src/test/java/org/apache/camel/quarkus/component/kamelet/it/KameletTest.java
Outdated
Show resolved
Hide resolved
|
Nice to see all this non functional code ;) |
lburgazzoli
force-pushed
the
camel-core-align
branch
from
73dd39c
to
f62c444
Compare
jamesnetherton
approved these changes
Jun 9, 2021
ppalaga
reviewed
Jun 9, 2021
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Looks like you have added a byte order mark. Any reason for that?
$ hexdump -n 3 -C pom.xml
00000000 ef bb bf |...|
before the change:
$ hexdump -n 3 -C pom.xml
00000000 3c 3f 78 |<?x|
|
no reason |
|
Thanks, let me revert the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.