Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-20850: camel-core - compress changes in SimpleLRUCache #14424

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Jun 7, 2024

Fix for https://issues.apache.org/jira/browse/CAMEL-20850

Motivation

When the queue of changes is full, some entries can be evicted while the cache is not, which is not expected.

Modifications:

  • Compress the changes by removing duplicates before the eviction
  • Add a minimum size for the queue of changes

Copy link
Contributor

github-actions bot commented Jun 7, 2024

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@essobedo essobedo marked this pull request as draft June 8, 2024 08:56
@essobedo essobedo force-pushed the CAMEL-20850/compress-changes branch 4 times, most recently from 0fc53a6 to 8d894bb Compare June 10, 2024 08:08
@gnodet gnodet self-requested a review June 10, 2024 20:32
@essobedo essobedo force-pushed the CAMEL-20850/compress-changes branch from 8d894bb to a79b5cb Compare June 10, 2024 21:06
@essobedo essobedo marked this pull request as ready for review June 11, 2024 06:14
@essobedo essobedo force-pushed the CAMEL-20850/compress-changes branch from a79b5cb to 2665178 Compare June 11, 2024 06:29
@essobedo essobedo force-pushed the CAMEL-20850/compress-changes branch from a45e0c3 to 4ee9623 Compare June 11, 2024 09:16
@essobedo essobedo force-pushed the CAMEL-20850/compress-changes branch from 4ee9623 to acc09bd Compare June 11, 2024 09:31
@essobedo
Copy link
Contributor Author

@gnodet Hi, any remarks/comments before I merge it?

@essobedo essobedo merged commit cbe31f9 into main Jun 11, 2024
4 checks passed
@essobedo essobedo deleted the CAMEL-20850/compress-changes branch June 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants