Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel metrics #210

Closed
wants to merge 24 commits into from
Closed

Camel metrics #210

wants to merge 24 commits into from

Conversation

laurikimmel
Copy link
Contributor

Camel Metrics component.

@davsclaus
Copy link
Contributor

Hi do you mind creating a new PR with the component added to the master branch of Apache Camel, and where the component is added to the components directory, where all the other components are.

The current patch / PR cannot be applied without a lot of work on our end.

@laurikimmel
Copy link
Contributor Author

I will look the master branch issue.

The second issue looks strange to me since new files are added to components/camel-metrics folder next to all other components. When I tested with local merge to master all files where there as expected. So it's hard for me to understand what exactly is misplaced.

Also noticed that some of the unit tests in camel-metrics component are broken after update from main repository. I will update them as needed.

@laurikimmel laurikimmel mentioned this pull request Jul 30, 2014
@laurikimmel
Copy link
Contributor Author

Merged Camel Metric component to master branch, fixed unit tests and created new pull request #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants