Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertow does not shut down properly in webhook route policy #3289

Merged
merged 1 commit into from
Oct 28, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -337,15 +337,23 @@ public HttpHandler registerEndpoint(HttpHandlerRegistrationInfo registrationInfo

host.validateEndpointURI(uri);
handlers.add(registrationInfo);

return host.registerHandler(registrationInfo, handler);
}

public void unregisterEndpoint(HttpHandlerRegistrationInfo registrationInfo, SSLContext sslContext) {
final URI uri = registrationInfo.getUri();
final UndertowHostKey key = new UndertowHostKey(uri.getHost(), uri.getPort(), sslContext);
final UndertowHost host = undertowRegistry.get(key);

handlers.remove(registrationInfo);
host.unregisterHandler(registrationInfo);

// if the route is not automatically started, then the undertow registry
// may not have any instance of UndertowHost associated to the given
// registrationInfo
if (host != null) {
host.unregisterHandler(registrationInfo);
}
}

protected UndertowHost createUndertowHost(UndertowHostKey key) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.camel.component.undertow;

import org.apache.camel.builder.RouteBuilder;
import org.junit.Test;

public class UndertowNoAutoStartupTest extends BaseUndertowTest {
@Test
public void testUndertow() throws Exception {
}

@Override
protected RouteBuilder createRouteBuilder() throws Exception {
return new RouteBuilder() {
public void configure() {
from("undertow:http://localhost:{{port}}/myapp")
.autoStartup(false)
.to("mock:myapp");
}
};
}
}