-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an extra output to the DM shell command which generates plantum… #381
base: master
Are you sure you want to change the base?
Conversation
…l output to quickly see the resolved and not-resolved dependencies
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 72.05% 71.93% -0.12%
==========================================
Files 219 219
Lines 35620 35674 +54
==========================================
- Hits 25665 25663 -2
- Misses 9955 10011 +56
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting addition, but I am missing the tests to verify the functionality.
See for example the query shell test:
https://github.com/apache/celix/blob/master/bundles/shell/shell/gtest/src/ShellTestSuite.cc#L138-L170
Also the meta info for the dm command should be updated to reflect the added functionality:
https://github.com/apache/celix/blob/master/bundles/shell/shell/src/std_commands.c#L101-L107
Is it maybe possible to move the generate plantuml from dependency manager info to a separate header/source file and test the output in combination with a plantuml package. If this works the GitHub ubuntu workflow can be updated with the And maybe with cmake |
Nice feature. |
Added an "u" option to the DM shell command which outputs plantuml. Copy paste this to a file, generate a graph wihl plantuml (see platuml.com: java -jar plantump.jar ) this will quickly show:
Dependencies are shown purely on component-name basis. (Missing) dependencies caused by filters are not shown.