CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migration #2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvazquez
force-pushed
the
CLOUDSTACK-9854
branch
4 times, most recently
from
0c6fdf5
to
2542e12
Compare
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-603 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-967)
|
nvazquez
force-pushed
the
CLOUDSTACK-9854
branch
from
2542e12
to
271467b
Compare
|
Thanks @borisstoyanov, I made little refactor due to failure, can you please re kick tests? |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-604 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
nvazquez
force-pushed
the
CLOUDSTACK-9854
branch
2 times, most recently
from
a189dc1
to
437d4ba
Compare
|
@karuturi sure, done! I rebased master and pushed, now Travis passes! |
|
Trillian test result (tid-968)
|
nvazquez
force-pushed
the
CLOUDSTACK-9854
branch
from
437d4ba
to
11562dc
Compare
|
LGTM for the code changes |
|
Wonderful. Seeing green travis after a long time :) 👍 |
asfgit
pushed a commit
that referenced
this pull request
Mar 31, 2017
CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migrationFix for test_primary_storage integration tests on simulator. When finding storage pool migration options for volume on running vm, API returns None as hypervisor doesn't support live migration. ```` 2017-03-28 06:07:55,958 - DEBUG - ========Sending GET Cmd : findStoragePoolsForMigration======= 2017-03-28 06:07:55,977 - DEBUG - Response : None 2017-03-28 06:07:55,983 - CRITICAL - EXCEPTION: test_03_migration_options_storage_tags: ['Traceback (most recent call last):\n', ' File "/opt/python/2.7.12/lib/python2.7/unittest/case.py", line 329, in run\n testMethod()\n', ' File "/home/travis/.local/lib/python2.7/site-packages/marvin/lib/decoratorGenerators.py", line 30, in test_wrapper\n return test(self, *args, **kwargs)\n', ' File "/home/travis/build/apache/cloudstack/test/integration/smoke/test_primary_storage.py", line 547, in test_03_migration_options_storage_tags\n pools_suitable = filter(lambda p : p.suitableformigration, pools_response)\n', "TypeError: 'NoneType' object is not iterable\n"] ```` So we simply stop vm before sending findStoragePoolsForMigration command * pr/2021: CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migration Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for test_primary_storage integration tests on simulator.
When finding storage pool migration options for volume on running vm, API returns None as hypervisor doesn't support live migration.
So we simply stop vm before sending findStoragePoolsForMigration command