API: move ostypeid from DB id to DB uuid, backports #2528

[borisstoyanov]

Description

This is a backport to 4.11 of #2528

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• Bug fix (non-breaking change which fixes an issue)

Screenshots (if appropriate):

How Has This Been Tested?

Locally

[rohityadavcloud]

LGTM, same as the already merged PR on master.

[rohityadavcloud]

This is same as: #2608
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2472

[borisstoyanov]

@blueorangutan test

[blueorangutan]

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[borisstoyanov]

With these changes response looks like this:

(localcloud) SBCM5> > list virtualmachines id=6110274a-b86e-4964-b964-f54fec0360e2 filter=name,ostypeid
{
  "count": 1,
  "virtualmachine": [
    {
      "name": "VM-6110274a-b86e-4964-b964-f54fec0360e2",
      "ostypeid": "d4db1769-f3be-11e8-86d3-063e32010711"
    }
  ]
}

[wido]

LGTM based on the code

We should never return the database IDs, but return a UUID in all cases.

[resmo]

LGTM

[blueorangutan]

Trillian test result (tid-3236)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22942 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3066-t3236-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 67 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_cancel_host_maintenace_with_migration_jobs	Error	1.21	test_host_maintenance.py