Fix null pointer exception in restore VM #8930

vishesh92 · 2024-04-17T09:23:45Z

Description

This PR fixes null pointer exception in restore VM.

2024-04-16T17:32:47,596 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-50:[ctx-969d6ccf, job-1648]) (logid:4eaa9a49) Unexpected exception while executing org.apache.cloudstack.api.command.user.vm.RestoreVMCmd java.lang.NullPointerE
xception
        at com.cloud.vm.UserVmManagerImpl.restoreVM(UserVmManagerImpl.java:7855)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
        at com.sun.proxy.$Proxy203.restoreVM(Unknown Source)
        at org.apache.cloudstack.api.command.user.vm.RestoreVMCmd.execute(RestoreVMCmd.java:101)
        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:173)
        at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:110)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:652)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46)
        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:600)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2024-04-17T09:24:15Z

@blueorangutan package

blueorangutan · 2024-04-17T09:26:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

vishesh92 · 2024-04-17T10:27:34Z

@blueorangutan package

blueorangutan · 2024-04-17T10:28:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-17T10:33:48Z

Packaging result [SF]: ✖️ el7 ✔️ debian. SL-JID 9288

DaanHoogland

clgtm

DaanHoogland · 2024-04-17T10:36:34Z

@blueorangutan package

blueorangutan · 2024-04-17T10:38:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-04-17T11:31:41Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9289

vishesh92 · 2024-04-17T11:32:44Z

@blueorangutan test

blueorangutan · 2024-04-17T11:34:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-04-17T11:41:37Z

[SF] Trillian Build Failed (tid-9882)

vishesh92 · 2024-04-17T11:42:24Z

@blueorangutan test

blueorangutan · 2024-04-17T11:44:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-04-17T11:48:36Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9290

weizhouapache

code lgtm

blueorangutan · 2024-04-18T01:24:08Z

[SF] Trillian test result (tid-9883)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47528 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8930-t9883-kvm-centos7.zip
Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	411.74	test_events_resource.py
test_02_trigger_shutdown	`Failure`	346.70	test_safe_shutdown.py

vishesh92 · 2024-04-18T05:33:25Z

@blueorangutan package

blueorangutan · 2024-04-18T05:34:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov-commenter · 2024-04-18T05:35:08Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 17.36%. Comparing base (c25264b) to head (8109d69).
Report is 23 commits behind head on 4.19.

Files	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##               4.19    #8930       +/-   ##
=============================================
- Coverage     30.98%   17.36%   -13.62%     
+ Complexity    34408    15865    -18543     
=============================================
  Files          5359     4863      -496     
  Lines        377017   326037    -50980     
  Branches      54856    45841     -9015     
=============================================
- Hits         116804    56626    -60178     
- Misses       244852   261162    +16310     
+ Partials      15361     8249     -7112

Flag	Coverage Δ
simulator-marvin-tests	`17.36% <0.00%> (-7.45%)`	⬇️
uitests	`?`
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-04-18T06:44:24Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9302

weizhouapache · 2024-04-18T07:53:09Z

@blueorangutan test rocky8 kvm-rocky8

blueorangutan · 2024-04-18T07:54:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

sureshanaparti

clgtm

blueorangutan · 2024-04-18T21:15:53Z

[SF] Trillian test result (tid-9896)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8930-t9896-kvm-rocky8.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	`Error`	416.84	test_events_resource.py

weizhouapache · 2024-04-22T17:20:53Z

This is a regression issue of #8800

step to reproduce the issue:

restore vm
prior to this PR: got NPE exception
with this PR: it works

borisstoyanov

LGTM, I could not see the error any more.

rohityadavcloud approved these changes Apr 17, 2024

View reviewed changes

rohityadavcloud added this to the 4.19.1.0 milestone Apr 17, 2024

rohityadavcloud requested review from DaanHoogland, sureshanaparti and borisstoyanov April 17, 2024 09:48

weizhouapache reviewed Apr 17, 2024

View reviewed changes

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated Show resolved Hide resolved

vishesh92 force-pushed the fix-npe-restore-vm branch from 54c5f67 to 27bf825 Compare April 17, 2024 10:11

vishesh92 requested a review from weizhouapache April 17, 2024 10:11

DaanHoogland approved these changes Apr 17, 2024

View reviewed changes

weizhouapache approved these changes Apr 17, 2024

View reviewed changes

rohityadavcloud marked this pull request as ready for review April 18, 2024 04:20

Fix null pointer exception in restore VM

8109d69

vishesh92 force-pushed the fix-npe-restore-vm branch from 27bf825 to 8109d69 Compare April 18, 2024 05:33

weizhouapache mentioned this pull request Apr 18, 2024

Unstable 4.19 and main branch smoketests #8931

Open

sureshanaparti approved these changes Apr 18, 2024

View reviewed changes

DaanHoogland added the status:needs-testing label Apr 19, 2024

weizhouapache added type:bug Severity:Critical Critical bug labels Apr 22, 2024

weizhouapache removed the status:needs-testing label Apr 22, 2024

weizhouapache merged commit c081f60 into apache:4.19 Apr 22, 2024
6 of 24 checks passed

DaanHoogland deleted the fix-npe-restore-vm branch April 23, 2024 06:23

borisstoyanov reviewed Apr 24, 2024

View reviewed changes

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024

server: Fix null pointer exception in restore VM (apache#8930)

3a5a8ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix null pointer exception in restore VM #8930

Fix null pointer exception in restore VM #8930

vishesh92 commented Apr 17, 2024 •

edited by weizhouapache

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

DaanHoogland left a comment

DaanHoogland commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

weizhouapache left a comment

blueorangutan commented Apr 18, 2024

vishesh92 commented Apr 18, 2024

blueorangutan commented Apr 18, 2024

codecov-commenter commented Apr 18, 2024 •

edited

blueorangutan commented Apr 18, 2024

weizhouapache commented Apr 18, 2024

blueorangutan commented Apr 18, 2024

sureshanaparti left a comment

blueorangutan commented Apr 18, 2024

weizhouapache commented Apr 22, 2024

borisstoyanov left a comment

Fix null pointer exception in restore VM #8930

Fix null pointer exception in restore VM #8930

Conversation

vishesh92 commented Apr 17, 2024 • edited by weizhouapache

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

DaanHoogland left a comment

Choose a reason for hiding this comment

DaanHoogland commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

vishesh92 commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

blueorangutan commented Apr 17, 2024

weizhouapache left a comment

Choose a reason for hiding this comment

blueorangutan commented Apr 18, 2024

vishesh92 commented Apr 18, 2024

blueorangutan commented Apr 18, 2024

codecov-commenter commented Apr 18, 2024 • edited

Codecov Report

blueorangutan commented Apr 18, 2024

weizhouapache commented Apr 18, 2024

blueorangutan commented Apr 18, 2024

sureshanaparti left a comment

Choose a reason for hiding this comment

blueorangutan commented Apr 18, 2024

weizhouapache commented Apr 22, 2024

borisstoyanov left a comment

Choose a reason for hiding this comment

vishesh92 commented Apr 17, 2024 •

edited by weizhouapache

codecov-commenter commented Apr 18, 2024 •

edited