Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page #9288

Conversation

sureshanaparti
Copy link
Contributor

Description

This PR fixes action buttons view when public IP address is selected, in Network -> Public IP addresses page

Fixes #8106

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before Fix =>

UI_PublicIPAddrBeforeFix

After Fix =>

UI_PublicIPAddrAfterFix

How Has This Been Tested?

Accessed Network -> Public IP addresses page in UI, and selected public IP address & checked the action buttons.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti added this to the 4.19.1.0 milestone Jun 24, 2024
@sureshanaparti sureshanaparti linked an issue Jun 24, 2024 that may be closed by this pull request
@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti force-pushed the ui-network-public-ip-action-buttons-view branch from 9d4c59d to 451ce19 Compare June 24, 2024 04:49
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.98%. Comparing base (0b857de) to head (73173fe).
Report is 149 commits behind head on 4.19.

Additional details and impacted files
@@              Coverage Diff              @@
##               4.19    #9288       +/-   ##
=============================================
- Coverage     30.70%   14.98%   -15.72%     
+ Complexity    34232    11051    -23181     
=============================================
  Files          5376     5389       +13     
  Lines        378222   470581    +92359     
  Branches      55053    60932     +5879     
=============================================
- Hits         116135    70528    -45607     
- Misses       246719   392216   +145497     
+ Partials      15368     7837     -7531     
Flag Coverage Δ
simulator-marvin-tests ?
uitests 4.28% <ø> (-0.04%) ⬇️
unittests 15.70% <ø> (-0.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9288 (QA-JID-385)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this a solution.

It creates a weird gap between actions and searchview when the screen is big and when the screen/window is small it still shows actions in a vertical manner.
Screenshot from 2024-06-24 11-30-13
Screenshot from 2024-06-24 11-29-41

I feel actions can be shown in a responsive manner showing a some kind of dropdown for actions when there is not enough space

@sureshanaparti sureshanaparti changed the title [UI] Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page [WIP] UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page Jun 25, 2024
@sureshanaparti sureshanaparti changed the title [WIP] UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page Jun 25, 2024
@sureshanaparti
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9288 (QA-JID-387)

@vishesh92 vishesh92 marked this pull request as ready for review June 26, 2024 05:10
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the Public IP view looks okay now, other views may not be looking the same,
Public IP
Screenshot from 2024-06-26 13-24-37

Instances
Screenshot from 2024-06-26 13-25-33

@sureshanaparti
Copy link
Contributor Author

While the Public IP view looks okay now, other views may not be looking the same

Got it, thanks for testing @shwstppr

@sureshanaparti sureshanaparti modified the milestones: 4.19.1.0, unplanned Jun 28, 2024
@sureshanaparti sureshanaparti deleted the ui-network-public-ip-action-buttons-view branch June 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI glitch when a public IP address is selected on the page
5 participants