-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix action buttons view when public IP address is selected, in Network -> Public IP addresses page #9288
Conversation
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
…pdated search view width
9d4c59d
to
451ce19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9288 +/- ##
=============================================
- Coverage 30.70% 14.98% -15.72%
+ Complexity 34232 11051 -23181
=============================================
Files 5376 5389 +13
Lines 378222 470581 +92359
Branches 55053 60932 +5879
=============================================
- Hits 116135 70528 -45607
- Misses 246719 392216 +145497
+ Partials 15368 7837 -7531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this a solution.
It creates a weird gap between actions and searchview when the screen is big and when the screen/window is small it still shows actions in a vertical manner.
I feel actions can be shown in a responsive manner showing a some kind of dropdown for actions when there is not enough space
…esses, updated search view width" This reverts commit 451ce19.
…k -> Public IP addresses page
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks for testing @shwstppr |
Description
This PR fixes action buttons view when public IP address is selected, in Network -> Public IP addresses page
Fixes #8106
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before Fix =>
After Fix =>
How Has This Been Tested?
Accessed Network -> Public IP addresses page in UI, and selected public IP address & checked the action buttons.
How did you try to break this feature and the system with this change?