-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added domain path to all entities #9540
Conversation
@blueorangutan package |
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9540 +/- ##
============================================
- Coverage 15.08% 15.08% -0.01%
Complexity 11184 11184
============================================
Files 5406 5406
Lines 472889 473034 +145
Branches 57738 60952 +3214
============================================
+ Hits 71352 71363 +11
- Misses 393593 393728 +135
+ Partials 7944 7943 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10692 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, The domainpath is present in the apiresponses
(cmk) > list networks filter=name,doaminid,domainpath listall=true
{
"count": 3,
"network": [
{
"domainpath": "/domain2/",
"name": "test2domain2"
},
{
"domainpath": "/domain1/",
"name": "account1net"
},
{
"domainpath": "/",
"name": "test"
}
]
}
(cmk) > list virtualmachines filter=name,domainid,domainpath listall=true
{
"count": 3,
"virtualmachine": [
{
"domainid": "12a1d40e-612c-11ef-ba9c-1e0027000437",
"domainpath": "/",
"name": "VM-eae4ab5f-c603-4009-a6a5-23130fbf43d7"
},
{
"domainid": "a3dd29d3-243f-44f6-a16b-6248b04cd3eb",
"domainpath": "/domain1/",
"name": "vm2"
},
{
"domainid": "a995ca47-c759-4ac2-9447-3d86446a4158",
"domainpath": "/domain2/",
"name": "vm3"
}
]
}
@blueorangutan test |
@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-11159)
|
Description
This PR fixes the ticket #8086. Added domain path to all the responses whereever domain and domain names are already used.
Added domain path to all the responses which implements the interfaces ControlledViewEntityResponse and ControlledEntityResponse
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?
(localcloud) 🐱 > list virtualmachines filter=name,domainpath,domain
{
"count": 6,
"virtualmachine": [
{
"domain": "ROOT",
"domainpath": "/",
"name": "Vm1N1"
},
{
List of responses where we have added the domain paths are
From ControlledEntityResponse:
From ControlledViewEntityResponse