Added domain path to all entities

[harikrishna-patnala]

Description

This PR fixes the ticket #8086. Added domain path to all the responses whereever domain and domain names are already used.

Added domain path to all the responses which implements the interfaces ControlledViewEntityResponse and ControlledEntityResponse

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

(localcloud) 🐱 > list virtualmachines filter=name,domainpath,domain
{
"count": 6,
"virtualmachine": [
{
"domain": "ROOT",
"domainpath": "/",
"name": "Vm1N1"
},
{

List of responses where we have added the domain paths are

From ControlledEntityResponse:

ServiceInstanceResponse
KubernetesClusterResponse
ConditionResponse
VpnUsersResponse
StaticRouteResponse
VlanIpRangeResponse
ResourceLimitResponse
AutoScaleVmProfileResponse
RemoteAccessVpnResponse
GuestVlanRangeResponse
ApplicationLoadBalancerResponse
UserDataResponse
AutoScalePolicyResponse
UserVmResponse
GlobalLoadBalancerResponse
VirtualRouterProviderResponse
NetworkResponse
Site2SiteVpnGatewayResponse
LoadBalancerResponse
VpcResponse
UsageRecordResponse
Site2SiteCustomerGatewayResponse
PrivateGatewayResponse
IPAddressResponse
GuestVlanResponse
Site2SiteVpnConnectionResponse
ResourceCountResponse
AcquireIPAddressResponse
AutoScaleVmGroupResponse
VMSnapshotResponse

From ControlledViewEntityResponse

AffinityGroupResponse
TemplateResponse
BucketResponse
EventResponse
SecurityGroupResponse
DomainRouterResponse
VolumeResponse
ResourceTagResponse
InstanceGroupResponse
SnapshotResponse
ProjectInvitationResponse
ProjectAccountResponse

[harikrishna-patnala]

@blueorangutan package

[blueorangutan]

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 13.10345% with 126 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (6e6a276) to head (79c7adc).
Report is 7 commits behind head on 4.19.

Files	Patch %	Lines
...src/main/java/com/cloud/api/ApiResponseHelper.java	33.33%	6 Missing ⚠️
...che/cloudstack/affinity/AffinityGroupResponse.java	0.00%	3 Missing ⚠️
...udstack/api/response/AcquireIPAddressResponse.java	0.00%	3 Missing ⚠️
.../api/response/ApplicationLoadBalancerResponse.java	0.00%	3 Missing ⚠️
...oudstack/api/response/AutoScalePolicyResponse.java	0.00%	3 Missing ⚠️
...apache/cloudstack/api/response/BucketResponse.java	0.00%	3 Missing ⚠️
...che/cloudstack/api/response/ConditionResponse.java	0.00%	3 Missing ⚠️
.../cloudstack/api/response/DomainRouterResponse.java	0.00%	3 Missing ⚠️
...stack/api/response/GlobalLoadBalancerResponse.java	0.00%	3 Missing ⚠️
...loudstack/api/response/GuestVlanRangeResponse.java	0.00%	3 Missing ⚠️
... and 40 more

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9540      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
  Complexity    11184    11184              
============================================
  Files          5406     5406              
  Lines        472889   473034     +145     
  Branches      57738    60952    +3214     
============================================
+ Hits          71352    71363      +11     
- Misses       393593   393728     +135     
+ Partials       7944     7943       -1     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.80% <13.10%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10692

[vishesh92]

clgtm

[DaanHoogland]

clgtm

[kiranchavala]

LGTM, The domainpath is present in the apiresponses

(cmk) > list networks filter=name,doaminid,domainpath listall=true
{
  "count": 3,
  "network": [
    {
      "domainpath": "/domain2/",
      "name": "test2domain2"
    },
    {
      "domainpath": "/domain1/",
      "name": "account1net"
    },
    {
      "domainpath": "/",
      "name": "test"
    }
  ]
}

(cmk)  > list virtualmachines filter=name,domainid,domainpath listall=true
{
  "count": 3,
  "virtualmachine": [
    {
      "domainid": "12a1d40e-612c-11ef-ba9c-1e0027000437",
      "domainpath": "/",
      "name": "VM-eae4ab5f-c603-4009-a6a5-23130fbf43d7"
    },
    {
      "domainid": "a3dd29d3-243f-44f6-a16b-6248b04cd3eb",
      "domainpath": "/domain1/",
      "name": "vm2"
    },
    {
      "domainid": "a995ca47-c759-4ac2-9447-3d86446a4158",
      "domainpath": "/domain2/",
      "name": "vm3"
    }
  ]
}

[kiranchavala]

@blueorangutan test

[blueorangutan]

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11159)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46917 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9540-t11159-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File