Use SystemProperties instead of a magic string lookup

Author: garydgregory

src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveEntry.java

@@ -53,6 +53,7 @@
 import org.apache.commons.compress.utils.ParsingUtils;
 import org.apache.commons.compress.utils.TimeUtils;
 import org.apache.commons.io.file.attribute.FileTimes;
+import org.apache.commons.lang3.SystemProperties;
 
 /**
  * This class represents an entry in a Tar archive. It consists of the entry's header, as well as the entry's File. Entries can be instantiated in one of three
@@ -227,7 +228,7 @@ private static FileTime fileTimeFromOptionalSeconds(final long seconds) {
      */
     private static String normalizeFileName(String fileName, final boolean preserveAbsolutePath) {
         if (!preserveAbsolutePath) {
-            final String property = System.getProperty("os.name");
+            final String property = SystemProperties.getOsName();
             if (property != null) {
                 final String osName = property.toLowerCase(Locale.ROOT);
 

src/test/java/org/apache/commons/compress/archivers/tar/TarArchiveEntryTest.java

@@ -44,12 +44,13 @@
 
 import org.apache.commons.compress.AbstractTest;
 import org.apache.commons.compress.archivers.zip.ZipEncodingHelper;
+import org.apache.commons.lang3.SystemProperties;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.EnabledOnOs;
 
 public class TarArchiveEntryTest implements TarConstants {
 
-    private static final String OS = System.getProperty("os.name").toLowerCase(Locale.ENGLISH);
+    private static final String OS = SystemProperties.getOsName().toLowerCase(Locale.ROOT);
     private static final String ROOT = OS.startsWith("windows") || OS.startsWith("netware") ? "C:\\" : "/";
 
     private void assertGnuMagic(final TarArchiveEntry t) {