Fix for incorrect handling of embedded quotes when printing from Read… #78
Conversation
…er and to related test; added new test class to further exercise CSVFormat.printWithQuotes(Reader,Appendable) for expected behavior.
Reader and to related test; added new test class to further exercise CSVFormat.printWithQuotes(Reader,Appendable) for expected behavior.
…ticgeek/commons-csv into fix-print-quoted-from-reader
|
May you please rebase on master? |
|
Hi Gary, I tried this morning to do what you have reasonably asked of me. While trying "rebase my patch" on master, I think what I've done now is merged all of the changes which have occurred in master since my original repository fork into my patch fork instead of committing just my changes updated relative to what is now on master. And I don't know how to fix it so that my patch is nice and clean like I took the time to do originally a year ago. My patch in this pull request is an important fix that I would like to see merged so I can stop working around the bug. I understand abstractly what you want me to do, and making the code changes was easy enough, but I just don't understand git well enough to satisfy your ask. I'm willing to try to fix this with your guidance but otherwise I don't know how to proceed and I'm sorry about that. |
|
@arcticgeek |
There was a problem hiding this comment.
I have carefully looked at the changes again, marked all the files as viewed, and then submitted this comment in review of the pull. This simple refactoring of CSVFormat.printWithQuotes(Reader, Appendable) addresses the embedding issue and the included test case is valid for exercising this method to ensure correct behavior in the future.
|
@arcticgeek |
…rebase for merging this pull request
There was a problem hiding this comment.
The original test case CSVFormatTest.testPrintWithQuotes() was confirming the incorrect behavior and somehow I forgot to include my adjustment to it with my rebase commit.
This fix to the original test case is what prompted me to further exercise the CSVFormat.printWithQuotes() method with additional tests which are found in the JiraCsv263Test class.
|
@arcticgeek |
output. - Resolve conflicts from PR #78 by Jason A. Guild. - Don't use depreacted methods. - Javadoc. - Use final.
|
Closing, in git master now. |
Fix for incorrect handling of embedded quotes when printing from Reader and to related test; added new test class to further exercise CSVFormat.printWithQuotes(Reader,Appendable) for expected behavior. CSV-263